Bug 216426 – Let webkitDisplayingFullscreen() return true when a video element’s fullscreen mode is not VideoFullscreenModeNone

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Peng Liu]

Let webkitDisplayingFullscreen() return true when a video element’s fullscreen mode is not VideoFullscreenModeNone

[Peng Liu]

<rdar://67790759>

[Peng Liu]

Created attachment 408890 [details]
WIP patch v0

[Peng Liu]

Created attachment 408935 [details]
WIP patch v1

[Peng Liu]

Created attachment 409091 [details]
WIP patch v2

[Peng Liu]

Created attachment 409104 [details]
WIP patch v3

[Peng Liu]

Created attachment 409156 [details]
Update changelogs

[Peng Liu]

Created attachment 411804 [details]
Rebase the patch

[Jer Noble]

Comment on attachment 411804 [details]
Rebase the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411804&action=review

> Source/WebCore/html/HTMLMediaElement.cpp:5936
> +                if (mode == VideoFullscreenModeStandard)
> +                    m_waitingToEnterFullscreen = true;

It looks like this is the meat of the change. That we only set m_waitingToEnterFullscreen if we're entering "standard" fullscreen.

> Source/WebCore/html/HTMLMediaElement.cpp:6016
> +            setFullscreenMode(VideoFullscreenModeNone);

And this is the second functional part of the change, that when exitFullscreen() is called, we set the fullscreenMode to "none" if the old mode was "standard".

This all looks good to me; glad we can write more careful tests through Internals now.

[Peng Liu]

Created attachment 412065 [details]
Rebased patch for landing

[EWS]

Committed r268865: <https://trac.webkit.org/changeset/268865>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412065 [details].