Bug 216414 – Consolidate BaseDateAndTimeInputType and BaseChooserOnlyDateAndTimeInputType

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Aditya Keerthi]

BaseChooserOnlyDateAndTimeInputType is the only derived class of BaseDateAndTimeInputType.

[Aditya Keerthi]

Created attachment 408551 [details]
Patch

[Devin Rousso]

Comment on attachment 408551 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408551&action=review

r=me

> Source/WebCore/html/BaseDateAndTimeInputType.cpp:312
> +        return;
> +    DateTimeChooserParameters parameters;

NIT: I'd add a newline here

> Source/WebCore/html/BaseDateAndTimeInputType.h:46
> +enum class DateTimeFormatValidationResults : uint8_t {

NIT: should this be inside `BaseDateAndTimeInputType` instead of in the `WebCore` namespace?

> Source/WebCore/html/DateTimeLocalInputType.h:42
> +        : BaseDateAndTimeInputType(element) { }

Style: the `{ }` should probably be on separate lines too if the constructor is more than one line

> Source/WebCore/html/MonthInputType.h:42
> +        : BaseDateAndTimeInputType(element) { }

ditto (DateTimeLocalInputType.h:42)

> Source/WebCore/html/WeekInputType.h:42
> +        : BaseDateAndTimeInputType(element) { }

ditto (DateTimeLocalInputType.h:42)

[Aditya Keerthi]

Created attachment 408575 [details]
Patch for landing

[Aditya Keerthi]

(In reply to Devin Rousso from comment #2)
> Comment on attachment 408551 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=408551&action=review
> 
> r=me

Thanks for the review!

> > Source/WebCore/html/BaseDateAndTimeInputType.cpp:312
> > +        return;
> > +    DateTimeChooserParameters parameters;
> 
> NIT: I'd add a newline here

Added.

> > Source/WebCore/html/BaseDateAndTimeInputType.h:46
> > +enum class DateTimeFormatValidationResults : uint8_t {
> 
> NIT: should this be inside `BaseDateAndTimeInputType` instead of in the
> `WebCore` namespace?

Good idea! I also moved `DateTimeFormatValidator` inside `BaseDateAndTimeInputType`.
 
> > Source/WebCore/html/DateTimeLocalInputType.h:42
> > +        : BaseDateAndTimeInputType(element) { }
> 
> Style: the `{ }` should probably be on separate lines too if the constructor
> is more than one line

Done.

[EWS]

Committed r267003: <https://trac.webkit.org/changeset/267003>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 408575 [details].

[Radar WebKit Bug Importer]

<rdar://problem/68812903>