Bug 216402 - [webkitscmpy] Add Contributor object
Summary: [webkitscmpy] Add Contributor object
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-09-11 04:26 PDT by Jonathan Bedard
Modified: 2020-09-15 13:04 PDT (History)
4 users (show)

See Also:


Attachments
Patch (11.62 KB, patch)
2020-09-11 08:41 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff
Patch for landing (11.64 KB, patch)
2020-09-15 12:40 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2020-09-11 04:26:01 PDT
Create a class which stores information about contributors.
Comment 1 Jonathan Bedard 2020-09-11 04:27:52 PDT
At some point in the future, this class will be populated by contributors.json, but at the moment, this class is just used to parse out a contributor from changelogs.
Comment 2 Radar WebKit Bug Importer 2020-09-11 04:28:11 PDT
<rdar://problem/68702680>
Comment 3 Jonathan Bedard 2020-09-11 04:37:26 PDT
This change is being used to support https://bugs.webkit.org/show_bug.cgi?id=216404
Comment 4 Jonathan Bedard 2020-09-11 08:41:43 PDT
Created attachment 408535 [details]
Patch
Comment 5 dewei_zhu 2020-09-15 11:55:47 PDT
Comment on attachment 408535 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408535&action=review

> Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py:49
> +version = Version(0, 0, 5)

why do we bump version number by 2?
Comment 6 Jonathan Bedard 2020-09-15 12:26:59 PDT
(In reply to dewei_zhu from comment #5)
> Comment on attachment 408535 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=408535&action=review
> 
> > Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py:49
> > +version = Version(0, 0, 5)
> 
> why do we bump version number by 2?

Because https://bugs.webkit.org/show_bug.cgi?id=216422 was also in-flight.
Comment 7 Jonathan Bedard 2020-09-15 12:31:00 PDT
(In reply to Jonathan Bedard from comment #6)
> (In reply to dewei_zhu from comment #5)
> > Comment on attachment 408535 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=408535&action=review
> > 
> > > Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py:49
> > > +version = Version(0, 0, 5)
> > 
> > why do we bump version number by 2?
> 
> Because https://bugs.webkit.org/show_bug.cgi?id=216422 was also in-flight.

Now, I forgot to bump the version in that patch, so it turns out that is mistake!
Comment 8 Jonathan Bedard 2020-09-15 12:40:34 PDT
Created attachment 408845 [details]
Patch for landing
Comment 9 EWS 2020-09-15 13:04:04 PDT
Committed r267096: <https://trac.webkit.org/changeset/267096>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 408845 [details].