Bug 216386 - Don't assume byte code operands are uint32 JSValues
Summary: Don't assume byte code operands are uint32 JSValues
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-09-10 16:23 PDT by Saam Barati
Modified: 2020-09-14 09:51 PDT (History)
15 users (show)

See Also:

Attachments
patch (4.14 KB, patch)
2020-09-10 16:32 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2020-09-10 16:23:18 PDT 
We might exit from DFG, and they may not be uint32s.
Comment 1 Saam Barati 2020-09-10 16:32:40 PDT 
Created attachment 408495 [details]
patch
Comment 2 Yusuke Suzuki 2020-09-10 16:37:56 PDT 
Comment on attachment 408495 [details]
patch

r=me
Comment 3 Mark Lam 2020-09-10 20:29:17 PDT 
Comment on attachment 408495 [details]
patch

Nice.
Comment 4 EWS 2020-09-14 09:46:07 PDT 
Committed r267017: <https://trac.webkit.org/changeset/267017>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 408495 [details].
Comment 5 Radar WebKit Bug Importer 2020-09-14 09:47:17 PDT 
<rdar://problem/68860613>
Comment 6 Mark Lam 2020-09-14 09:51:31 PDT 
<rdar://problem/68463767>