Bug 216375 - Move _setCookieAcceptPolicy to WKHTTPCookieStore
Summary: Move _setCookieAcceptPolicy to WKHTTPCookieStore
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-09-10 12:35 PDT by Alex Christensen
Modified: 2020-09-11 15:03 PDT (History)
2 users (show)

See Also:


Attachments
Patch (19.30 KB, patch)
2020-09-10 13:04 PDT, Alex Christensen
ggaren: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2020-09-10 12:35:30 PDT
Remove unneeded WKContextUseTestingNetworkSession
Comment 1 Alex Christensen 2020-09-10 13:04:39 PDT
Created attachment 408471 [details]
Patch
Comment 2 Geoffrey Garen 2020-09-10 14:06:02 PDT
Comment on attachment 408471 [details]
Patch

r=me
Comment 3 Alex Christensen 2020-09-10 23:15:04 PDT
In order to adopt this SPI, Safari needs two more things:

1. An optional initial cookie accept policy on the WebsiteDataStoreConfiguration.  This is mostly used for ephemeral sessions, which would begin with the default cookie accept policy but we want to set it, in this case to be the same as the persistent cookie accept policy.
2. A way to update the cookie accept policies for all website data stores.  This could technically be done without SPI, but iterating all existing website data stores is a lot easier in WebKit because we already have nonDefaultDataStores().  I plan to implement this as a class method on WKWebsiteDataStore called something like +_setCookieAcceptPolicyOnAllWebsiteDataStores:completionHandler:

I plan to add these with tests in the morning.
Comment 4 Alex Christensen 2020-09-11 12:43:18 PDT
Just kidding.  I think those things are not actually necessary.
Comment 5 Alex Christensen 2020-09-11 15:02:14 PDT
http://trac.webkit.org/r266951
Comment 6 Radar WebKit Bug Importer 2020-09-11 15:03:35 PDT
<rdar://problem/68734104>