Bug 216362 - Upstream some additional feature defines
Summary: Upstream some additional feature defines
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-09-10 07:31 PDT by Tim Horton
Modified: 2020-09-17 07:31 PDT (History)
8 users (show)

See Also:

Attachments
Patch (2.45 KB, patch)
2020-09-10 07:31 PDT, Tim Horton 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (2.45 KB, patch)
2020-09-10 07:33 PDT, Tim Horton 		sam: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2020-09-10 07:31:02 PDT 
Upstream some additional feature defines
Comment 1 Tim Horton 2020-09-10 07:31:52 PDT 
Created attachment 408436 [details]
Patch
Comment 2 Tim Horton 2020-09-10 07:33:50 PDT 
Created attachment 408438 [details]
Patch
Comment 3 Sam Weinig 2020-09-10 07:52:52 PDT 
Comment on attachment 408438 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408438&action=review

> Source/WTF/wtf/PlatformHave.h:760
> +#define HAVE_SESSION_CLEANUP 1

This name seems too generic. What API is it wrapping?

> Source/WTF/wtf/PlatformHave.h:772
> +#define HAVE_QUICKBOARD_COLLECTION_VIEWS 1

Does Quickboard (whatever that is) have a prefix (NS,UI, etc.) that it uses?
Comment 4 Tim Horton 2020-09-10 10:30:05 PDT 
(In reply to Sam Weinig from comment #3)
> Comment on attachment 408438 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=408438&action=review
> 
> > Source/WTF/wtf/PlatformHave.h:760
> > +#define HAVE_SESSION_CLEANUP 1
> 
> This name seems too generic. What API is it wrapping?

I think it's wrong in more ways than that. It /looks/ like it should be an ENABLE or something (guarding WebKit behavior, not existence of a platform feature) but I can't quite tell what it is. Anyway, the name already exists, I'm just upstreaming its definition :)
Comment 5 Tim Horton 2020-09-10 10:30:55 PDT 
Ho boy, activateSessionCleanup is very confused, look at all those #ifdefs. Not gonna try to fix it right now.
Comment 6 Radar WebKit Bug Importer 2020-09-17 07:31:16 PDT 
<rdar://problem/69069506>