Bug 216332 - Update WPT test harness so that webaudio tests output results that are consistent across different machines
Summary: Update WPT test harness so that webaudio tests output results that are consis...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 212611
  Show dependency treegraph
 
Reported: 2020-09-09 15:43 PDT by Chris Dumez
Modified: 2023-02-14 13:39 PST (History)
13 users (show)

See Also:


Attachments
Patch (5.85 KB, patch)
2020-09-09 15:51 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (5.69 KB, patch)
2020-09-10 11:34 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (7.63 KB, patch)
2020-09-10 14:42 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (7.62 KB, patch)
2020-09-14 10:02 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (219.02 KB, patch)
2020-09-16 13:42 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (219.70 KB, patch)
2020-09-16 14:15 PDT, Chris Dumez
ews-feeder: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-09-09 15:43:05 PDT
Unskip some webaudio WPT tests that no longer appear to be flaky.
Comment 1 Chris Dumez 2020-09-09 15:51:29 PDT
Created attachment 408379 [details]
Patch
Comment 2 Chris Dumez 2020-09-10 11:34:36 PDT
Created attachment 408464 [details]
Patch
Comment 3 Chris Dumez 2020-09-10 14:42:35 PDT
Created attachment 408478 [details]
Patch
Comment 4 Chris Dumez 2020-09-14 10:02:04 PDT
Created attachment 408718 [details]
Patch
Comment 5 Chris Dumez 2020-09-16 13:42:11 PDT
Created attachment 408953 [details]
Patch
Comment 6 Chris Dumez 2020-09-16 14:15:24 PDT
Created attachment 408955 [details]
Patch
Comment 7 Geoffrey Garen 2020-09-16 15:12:12 PDT
Comment on attachment 408955 [details]
Patch

rs=me
Comment 8 EWS 2020-09-16 15:31:50 PDT
Committed r267167: <https://trac.webkit.org/changeset/267167>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 408955 [details].
Comment 9 Radar WebKit Bug Importer 2020-09-16 15:32:17 PDT
<rdar://problem/69019030>
Comment 10 Aakash Jain 2020-09-18 04:11:14 PDT
(In reply to EWS from comment #8)
> Committed r267167: <https://trac.webkit.org/changeset/267167>
This broke following two layout tests on ios-wk2 as also indicated by EWS (in  https://ews-build.webkit.org/#/builders/24/builds/25874)

- imported/w3c/web-platform-tests/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/mediaElementAudioSourceToScriptProcessorTest.html
- media/now-playing-status-without-media.html
Comment 11 Chris Dumez 2020-09-18 07:50:21 PDT
(In reply to Aakash Jain from comment #10)
> (In reply to EWS from comment #8)
> > Committed r267167: <https://trac.webkit.org/changeset/267167>
> This broke following two layout tests on ios-wk2 as also indicated by EWS
> (in  https://ews-build.webkit.org/#/builders/24/builds/25874)
> 
> -
> imported/w3c/web-platform-tests/webaudio/the-audio-api/the-
> mediaelementaudiosourcenode-interface/
> mediaElementAudioSourceToScriptProcessorTest.html
> - media/now-playing-status-without-media.html

This patch unskipped a lot of audio tests. Odds are these two either need iOS baselines or need to be reskipped if still flaky. I will check.
Comment 12 Chris Dumez 2020-09-18 08:29:58 PDT
(In reply to Chris Dumez from comment #11)
> (In reply to Aakash Jain from comment #10)
> > (In reply to EWS from comment #8)
> > > Committed r267167: <https://trac.webkit.org/changeset/267167>
> > This broke following two layout tests on ios-wk2 as also indicated by EWS
> > (in  https://ews-build.webkit.org/#/builders/24/builds/25874)
> > 
> > -
> > imported/w3c/web-platform-tests/webaudio/the-audio-api/the-
> > mediaelementaudiosourcenode-interface/
> > mediaElementAudioSourceToScriptProcessorTest.html

I rebaselined this test in:
http://trac.webkit.org/r267238

Will monitor to see if it is still flaky or not.

> > - media/now-playing-status-without-media.html 

This one looks green on the flakiness dashboard and looks unrelated to my change.