Bug 216329 - [CMake] Use imported targets in find module for libseccomp
Summary: [CMake] Use imported targets in find module for libseccomp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adrian Perez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-09-09 15:33 PDT by Adrian Perez
Modified: 2020-09-10 10:29 PDT (History)
10 users (show)

See Also:

Attachments
Patch (9.29 KB, patch)
2020-09-09 15:49 PDT, Adrian Perez 		no flags Details | Formatted Diff | Diff
Patch v2 (9.27 KB, patch)
2020-09-10 00:03 PDT, Adrian Perez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Perez 2020-09-09 15:33:56 PDT 
SSIA
Comment 1 Adrian Perez 2020-09-09 15:49:30 PDT 
Created attachment 408378 [details]
Patch
Comment 2 Konstantin Tokarev 2020-09-09 18:50:15 PDT 
Comment on attachment 408378 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408378&action=review

> Source/cmake/FindLibseccomp.cmake:55
> +find_package(PkgConfig)

find_package(PkgConfig QUIET)

find modules should find other modules with QUIET
Comment 3 Adrian Perez 2020-09-10 00:01:50 PDT 
(In reply to Konstantin Tokarev from comment #2)
> Comment on attachment 408378 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=408378&action=review
> 
> > Source/cmake/FindLibseccomp.cmake:55
> > +find_package(PkgConfig)
> 
> find_package(PkgConfig QUIET)
> 
> find modules should find other modules with QUIET

You're right; this one slipped in. Thanks for noticing!
Comment 4 Adrian Perez 2020-09-10 00:03:09 PDT 
Created attachment 408417 [details]
Patch v2
Comment 5 EWS 2020-09-10 10:28:17 PDT 
Committed r266833: <https://trac.webkit.org/changeset/266833>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 408417 [details].
Comment 6 Radar WebKit Bug Importer 2020-09-10 10:29:17 PDT 
<rdar://problem/68650472>