Bug 216314 - [WebRTC] Fix uninitialized fields in FilterAnalyzer::ConsistentFilterDetector, FilterAnalyzer::FilterAnalysisState and InterArrival::TimestampGroup
Summary: [WebRTC] Fix uninitialized fields in FilterAnalyzer::ConsistentFilterDetector...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-09-09 09:45 PDT by David Kilzer (:ddkilzer)
Modified: 2020-09-09 19:51 PDT (History)
8 users (show)

See Also:

Attachments
Patch v1 (3.72 KB, patch)
2020-09-09 10:25 PDT, David Kilzer (:ddkilzer) 		youennf: review+
Details | Formatted Diff | Diff
Patch for landing (7.61 KB, patch)
2020-09-09 19:15 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2020-09-09 09:45:56 PDT 
Fix uninitialized fields in FilterAnalyzer::ConsistentFilterDetector, FilterAnalyzer::FilterAnalysisState and InterArrival::TimestampGroup.

This is just a hardening task.

Found by clang static analyzer using the optin.cplusplus.UninitializedObject checker.
Comment 1 David Kilzer (:ddkilzer) 2020-09-09 10:25:23 PDT 
Created attachment 408338 [details]
Patch v1
Comment 2 David Kilzer (:ddkilzer) 2020-09-09 19:15:49 PDT 
Created attachment 408399 [details]
Patch for landing
Comment 3 David Kilzer (:ddkilzer) 2020-09-09 19:16:32 PDT 
Comment on attachment 408399 [details]
Patch for landing

Adding cq+ since this patch is identical to "Patch v1" except it includes a local copy of the patch for applying to future upstream merges.
Comment 4 Radar WebKit Bug Importer 2020-09-09 19:17:03 PDT 
<rdar://problem/68611826>
Comment 5 EWS 2020-09-09 19:51:45 PDT 
Committed r266810: <https://trac.webkit.org/changeset/266810>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 408399 [details].