Bug 216297 - WebCore UnifiedSource81 builds for upwards of 10 minutes
Summary: WebCore UnifiedSource81 builds for upwards of 10 minutes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-09-08 17:13 PDT by Tim Horton
Modified: 2020-09-08 20:15 PDT (History)
11 users (show)

See Also:

Attachments
Patch (1.61 KB, patch)
2020-09-08 17:13 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (1.60 KB, patch)
2020-09-08 17:24 PDT, Tim Horton 		simon.fraser: review+
thorton: commit-queue+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2020-09-08 17:13:42 PDT 
WebCore UnifiedSource81 builds for upwards of 10 minutes
Comment 1 Tim Horton 2020-09-08 17:13:53 PDT 
Created attachment 408289 [details]
Patch
Comment 2 Tim Horton 2020-09-08 17:22:58 PDT 
I suppose we need to restrict to clang only.
Comment 3 Tim Horton 2020-09-08 17:24:43 PDT 
Created attachment 408291 [details]
Patch
Comment 4 Alexey Proskuryakov 2020-09-08 17:41:51 PDT 
Comment on attachment 408291 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408291&action=review

> Source/WebCore/bindings/js/WebCoreBuiltinNames.h:463
> +    // FIXME: Remove the __attribute__((nodebug)) when <rdar://68246686> is fixed.

Fixed in all versions that we are building with...
Comment 5 Tim Horton 2020-09-08 18:56:31 PDT 
(In reply to Alexey Proskuryakov from comment #4)
> Comment on attachment 408291 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=408291&action=review
> 
> > Source/WebCore/bindings/js/WebCoreBuiltinNames.h:463
> > +    // FIXME: Remove the __attribute__((nodebug)) when <rdar://68246686> is fixed.
> 
> Fixed in all versions that we are building with...

Sure, or we can add conditional flags (I suppose I could have done that here, too, but I was too lazy to figure it out).
Comment 6 Tim Horton 2020-09-08 20:14:37 PDT 
Committed r266768: <https://trac.webkit.org/changeset/266768>
Comment 7 Radar WebKit Bug Importer 2020-09-08 20:15:25 PDT 
<rdar://problem/68546448>