WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
216297
WebCore UnifiedSource81 builds for upwards of 10 minutes
https://bugs.webkit.org/show_bug.cgi?id=216297
Summary
WebCore UnifiedSource81 builds for upwards of 10 minutes
Tim Horton
Reported
2020-09-08 17:13:42 PDT
WebCore UnifiedSource81 builds for upwards of 10 minutes
Attachments
Patch
(1.61 KB, patch)
2020-09-08 17:13 PDT
,
Tim Horton
no flags
Details
Formatted Diff
Diff
Patch
(1.60 KB, patch)
2020-09-08 17:24 PDT
,
Tim Horton
simon.fraser
: review+
thorton
: commit-queue+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Tim Horton
Comment 1
2020-09-08 17:13:53 PDT
Created
attachment 408289
[details]
Patch
Tim Horton
Comment 2
2020-09-08 17:22:58 PDT
I suppose we need to restrict to clang only.
Tim Horton
Comment 3
2020-09-08 17:24:43 PDT
Created
attachment 408291
[details]
Patch
Alexey Proskuryakov
Comment 4
2020-09-08 17:41:51 PDT
Comment on
attachment 408291
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=408291&action=review
> Source/WebCore/bindings/js/WebCoreBuiltinNames.h:463 > + // FIXME: Remove the __attribute__((nodebug)) when <
rdar://68246686
> is fixed.
Fixed in all versions that we are building with...
Tim Horton
Comment 5
2020-09-08 18:56:31 PDT
(In reply to Alexey Proskuryakov from
comment #4
)
> Comment on
attachment 408291
[details]
> Patch > > View in context: >
https://bugs.webkit.org/attachment.cgi?id=408291&action=review
> > > Source/WebCore/bindings/js/WebCoreBuiltinNames.h:463 > > + // FIXME: Remove the __attribute__((nodebug)) when <
rdar://68246686
> is fixed. > > Fixed in all versions that we are building with...
Sure, or we can add conditional flags (I suppose I could have done that here, too, but I was too lazy to figure it out).
Tim Horton
Comment 6
2020-09-08 20:14:37 PDT
Committed
r266768
: <
https://trac.webkit.org/changeset/266768
>
Radar WebKit Bug Importer
Comment 7
2020-09-08 20:15:25 PDT
<
rdar://problem/68546448
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug