Bug 216296 - Regression(r260614) Power usage has increased due to extra thread hopping
Summary: Regression(r260614) Power usage has increased due to extra thread hopping
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 208778
  Show dependency tree / graph
 
Reported: 2020-09-08 17:06 PDT by Chris Dumez
Modified: 2020-09-08 21:12 PDT (History)
5 users (show)

See Also:

Attachments
Patch (10.68 KB, patch)
2020-09-08 17:11 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (10.83 KB, patch)
2020-09-08 17:17 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (10.78 KB, patch)
2020-09-08 17:57 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-09-08 17:06:21 PDT 
Power usage has increased after 260614 due to extra thread hopping.
Comment 1 Chris Dumez 2020-09-08 17:06:33 PDT 
<rdar://problem/67719299>
Comment 2 Chris Dumez 2020-09-08 17:11:20 PDT 
Created attachment 408288 [details]
Patch
Comment 3 Chris Dumez 2020-09-08 17:17:52 PDT 
Created attachment 408290 [details]
Patch
Comment 4 Simon Fraser (smfr) 2020-09-08 17:52:50 PDT 
Comment on attachment 408290 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408290&action=review

> Source/WebKit/UIProcess/mac/DisplayLink.h:68
> +    static bool m_shouldSendIPCOnBackgroundQueue;

Should we use s_ for a static?
Comment 5 Chris Dumez 2020-09-08 17:57:11 PDT 
Created attachment 408297 [details]
Patch
Comment 6 EWS 2020-09-08 21:12:38 PDT 
Committed r266771: <https://trac.webkit.org/changeset/266771>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 408297 [details].