Bug 216284 - AudioParam.linearRampToValueAtTime() / exponentialRampToValueAtTime() have no effect when there is no preceding event
Summary: AudioParam.linearRampToValueAtTime() / exponentialRampToValueAtTime() have no...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 212611 216288
  Show dependency treegraph
 
Reported: 2020-09-08 14:27 PDT by Chris Dumez
Modified: 2020-09-09 11:01 PDT (History)
10 users (show)

See Also:


Attachments
Patch (14.68 KB, patch)
2020-09-08 15:23 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-09-08 14:27:23 PDT
AudioParam.linearRampToValueAtTime() / exponentialRampToValueAtTime() have no effect when there is no preceding event in the timeline. This is incorrect. We should insert an implicit SetValue event in the timeline if the ramp event is the first one.
Comment 1 Chris Dumez 2020-09-08 15:23:13 PDT
Created attachment 408273 [details]
Patch
Comment 2 Chris Dumez 2020-09-08 15:41:57 PDT
Comment on attachment 408273 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408273&action=review

> LayoutTests/imported/w3c/ChangeLog:8
> +        * web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-connections-expected.txt:

Fixing via https://bugs.webkit.org/show_bug.cgi?id=216288.
Comment 3 Chris Dumez 2020-09-09 10:49:21 PDT
Comment on attachment 408273 [details]
Patch

Patch is ready for review.
Comment 4 Chris Dumez 2020-09-09 11:00:35 PDT
Comment on attachment 408273 [details]
Patch

Clearing flags on attachment: 408273

Committed r266788: <https://trac.webkit.org/changeset/266788>
Comment 5 Chris Dumez 2020-09-09 11:00:37 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2020-09-09 11:01:16 PDT
<rdar://problem/68584175>