Bug 216279 - Fix precision issues in AudioParamTimeline when event times are very close
Summary: Fix precision issues in AudioParamTimeline when event times are very close
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 212611
  Show dependency tree / graph
 
Reported: 2020-09-08 11:49 PDT by Chris Dumez
Modified: 2020-09-08 13:25 PDT (History)
8 users (show)

See Also:

Attachments
Patch (1.26 MB, patch)
2020-09-08 11:57 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (1.26 MB, patch)
2020-09-08 12:11 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (1.30 MB, patch)
2020-09-08 12:42 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-09-08 11:49:16 PDT 
Fix precision issues in AudioParamTimeline when event times are very close.
Comment 1 Chris Dumez 2020-09-08 11:57:09 PDT 
Created attachment 408250 [details]
Patch
Comment 2 Darin Adler 2020-09-08 12:06:28 PDT 
Comment on attachment 408250 [details]
Patch

I see that the code involves a lot of floating point division. Last time I checked, I believe floating point multiplication was significantly faster. Perhaps we can make some of this division be multiplication by calculating a reciprocal or by reorganizing expressions. Or perhaps this kind of micro-optimization thinking is not relevant to this code.

r=me assuming the tests pass
Comment 3 Chris Dumez 2020-09-08 12:11:35 PDT 
Created attachment 408252 [details]
Patch
Comment 4 Chris Dumez 2020-09-08 12:42:59 PDT 
Created attachment 408255 [details]
Patch
Comment 5 EWS 2020-09-08 13:24:38 PDT 
Committed r266746: <https://trac.webkit.org/changeset/266746>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 408255 [details].
Comment 6 Radar WebKit Bug Importer 2020-09-08 13:25:28 PDT 
<rdar://problem/68526735>