Bug 216255 - [WebIDL] Add support for partial interface mixins
Summary: [WebIDL] Add support for partial interface mixins
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-09-07 15:23 PDT by Sam Weinig
Modified: 2020-09-08 14:47 PDT (History)
15 users (show)

See Also:

Attachments
Patch (179.11 KB, patch)
2020-09-07 19:00 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (168.84 KB, patch)
2020-09-08 10:15 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (168.85 KB, patch)
2020-09-08 10:38 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (170.93 KB, patch)
2020-09-08 12:27 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (191.84 KB, patch)
2020-09-08 14:11 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2020-09-07 15:23:04 PDT 
[WebIDL] Add support for partial interface mixins
Comment 1 Sam Weinig 2020-09-07 19:00:06 PDT Comment hidden (obsolete)
Comment 2 Sam Weinig 2020-09-08 10:15:01 PDT Comment hidden (obsolete)
Comment 3 Sam Weinig 2020-09-08 10:38:49 PDT Comment hidden (obsolete)
Comment 4 Sam Weinig 2020-09-08 12:27:51 PDT 
Created attachment 408254 [details]
Patch
Comment 5 Darin Adler 2020-09-08 12:50:41 PDT 
Comment on attachment 408254 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408254&action=review

> Source/WebCore/ChangeLog:35
> +        Move logic to avoid genertion of mixins and partial here.

generation typo here

> Source/WebCore/bindings/scripts/CodeGenerator.pm:212
> +    ${cppName} at every build. This file must not be tried to compile.

You replicated the tortured grammar: "This file must not be tried to compile." Let's just leave that worthless sentence out?
Comment 6 Sam Weinig 2020-09-08 14:11:17 PDT 
Created attachment 408267 [details]
Patch
Comment 7 EWS 2020-09-08 14:46:14 PDT 
Committed r266753: <https://trac.webkit.org/changeset/266753>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 408267 [details].
Comment 8 Radar WebKit Bug Importer 2020-09-08 14:47:16 PDT 
<rdar://problem/68531306>