Bug 216254 – [GTK] AcceleratedBackingStoreWayland might erroneously try to use SHM with older wpebackend-fdo

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Mike Gorse]

TryInitializeSHM has a wpebackend-fdo version check, but, for versions older than 1.7.0, it does the wrong thing and acts as though it has successfully initialized. Epiphany is currently coredumping with the openSUSE GNOME:Next repository (using webkitgtk 2.29.92), and I suspect that this is the reason.

[Mike Gorse]

Created attachment 408199 [details]
Patch.

[Darin Adler]

Comment on attachment 408199 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=408199&action=review

> Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreWayland.cpp:140
> +    return false;

We’d like to structure the #if so there is not dead code after a return.

So the code after the #endif should be moved before the #else.

[Mike Gorse]

Created attachment 408202 [details]
Patch.

[Adrian Perez]

Comment on attachment 408202 [details]
Patch.

Hello! Thanks for the patch, Michael. Could you please move the “return”
around as suggested by Darin? Other than that and adding the [WPE] tag
to the bug description, the change looks good =)

View in context: https://bugs.webkit.org/attachment.cgi?id=408202&action=review

> Source/WebKit/ChangeLog:3
> +        AcceleratedBackingStoreWayland might erroneously try to use SHM with older wpebackend-fdo

Let's also add the [WPE] tag to the bug description :)

[Carlos Garcia Campos]

This is a gtk bug, not WPE

[Mike Gorse]

Created attachment 408227 [details]
Patch.

Updated ChangeLog entry. I believe I have also done what Darin requested in terms of the return value.

[EWS]

Committed r266726: <https://trac.webkit.org/changeset/266726>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 408227 [details].