Bug 216249 - [css-flex] Don't skip flexboxes with auto height for percentage computations in quirks mode
Summary: [css-flex] Don't skip flexboxes with auto height for percentage computations ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sergio Villar Senin
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-09-07 12:32 PDT by Sergio Villar Senin
Modified: 2020-09-08 00:36 PDT (History)
12 users (show)

See Also:


Attachments
Patch (6.75 KB, patch)
2020-09-07 12:49 PDT, Sergio Villar Senin
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sergio Villar Senin 2020-09-07 12:32:58 PDT
[css-flex] Don't skip flexboxes with auto height for percentage computations in quirks mode
Comment 1 Sergio Villar Senin 2020-09-07 12:49:05 PDT
Created attachment 408193 [details]
Patch
Comment 2 zalan 2020-09-07 16:06:36 PDT
Comment on attachment 408193 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408193&action=review

> Source/WebCore/rendering/RenderBoxModelObject.cpp:291
> +    // We need the containing block to have a definite block-size in order to resolve the block-size of the descendant,
> +    // except when in quirks mode. Flexboxes follow strict behavior even in quirks mode, though.
> +    if (!cb || (document().inQuirksMode() && !cb->isFlexibleBoxIncludingDeprecated()))

This pretty much sums up what I dislike about the current RenderTree design.
Comment 3 Sergio Villar Senin 2020-09-08 00:35:57 PDT
Committed r266716: <https://trac.webkit.org/changeset/266716>
Comment 4 Radar WebKit Bug Importer 2020-09-08 00:36:17 PDT
<rdar://problem/68491400>