RESOLVED FIXED 216249
[css-flex] Don't skip flexboxes with auto height for percentage computations in quirks mode 
https://bugs.webkit.org/show_bug.cgi?id=216249
Summary [css-flex] Don't skip flexboxes with auto height for percentage computations ...
Sergio Villar Senin
Reported 2020-09-07 12:32:58 PDT
[css-flex] Don't skip flexboxes with auto height for percentage computations in quirks mode
Attachments
Patch (6.75 KB, patch)
2020-09-07 12:49 PDT, Sergio Villar Senin 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sergio Villar Senin
Comment 1 2020-09-07 12:49:05 PDT
Created attachment 408193 [details] Patch
zalan
Comment 2 2020-09-07 16:06:36 PDT
Comment on attachment 408193 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408193&action=review > Source/WebCore/rendering/RenderBoxModelObject.cpp:291 > + // We need the containing block to have a definite block-size in order to resolve the block-size of the descendant, > + // except when in quirks mode. Flexboxes follow strict behavior even in quirks mode, though. > + if (!cb || (document().inQuirksMode() && !cb->isFlexibleBoxIncludingDeprecated())) This pretty much sums up what I dislike about the current RenderTree design.
Sergio Villar Senin
Comment 3 2020-09-08 00:35:57 PDT
Committed r266716: <https://trac.webkit.org/changeset/266716>
Radar WebKit Bug Importer
Comment 4 2020-09-08 00:36:17 PDT
<rdar://problem/68491400>
Note You need to log in before you can comment on or make changes to this bug.