Bug 216231 - [WebIDL] Add mode to preprocess-idls.pl to validate fast regex based scanner with the normal IDL parser
Summary: [WebIDL] Add mode to preprocess-idls.pl to validate fast regex based scanner ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-09-06 15:11 PDT by Sam Weinig
Modified: 2020-09-06 17:21 PDT (History)
10 users (show)

See Also:

Attachments
Patch (42.35 KB, patch)
2020-09-06 15:39 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (42.82 KB, patch)
2020-09-06 16:03 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (40.46 KB, patch)
2020-09-06 16:05 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2020-09-06 15:11:47 PDT 
[WebIDL] Add mode to preprocess-idls.pl to validate fast regex based scanner with the normal IDL parser
Comment 1 Sam Weinig 2020-09-06 15:14:36 PDT 
I keep finding myself running into issues with preprocess-idls.pl, mostly due to its very optimistic parsing of IDL files not matching the actual IDL grammar.

One day, I would like to remove this alternative parsing, but as a first step, I want to add a mode I can run preprocess-idls.pl in that uses the real IDL parser to validate that the regex based one is getting the right results.
Comment 2 Sam Weinig 2020-09-06 15:39:16 PDT Comment hidden (obsolete)
Comment 3 Sam Weinig 2020-09-06 15:42:09 PDT 
Oh bummer, looks like I can't 'use experimental 'smartmatch';'
Comment 4 Sam Weinig 2020-09-06 16:03:46 PDT Comment hidden (obsolete)
Comment 5 Sam Weinig 2020-09-06 16:05:24 PDT 
Created attachment 408149 [details]
Patch
Comment 6 EWS 2020-09-06 17:20:05 PDT 
Committed r266687: <https://trac.webkit.org/changeset/266687>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 408149 [details].
Comment 7 Radar WebKit Bug Importer 2020-09-06 17:21:17 PDT 
<rdar://problem/68437813>