RESOLVED FIXED 216231
[WebIDL] Add mode to preprocess-idls.pl to validate fast regex based scanner with the normal IDL parser 
https://bugs.webkit.org/show_bug.cgi?id=216231
Summary [WebIDL] Add mode to preprocess-idls.pl to validate fast regex based scanner ...
Sam Weinig
Reported 2020-09-06 15:11:47 PDT
[WebIDL] Add mode to preprocess-idls.pl to validate fast regex based scanner with the normal IDL parser
Attachments
Patch (42.35 KB, patch)
2020-09-06 15:39 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (42.82 KB, patch)
2020-09-06 16:03 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (40.46 KB, patch)
2020-09-06 16:05 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2020-09-06 15:14:36 PDT
I keep finding myself running into issues with preprocess-idls.pl, mostly due to its very optimistic parsing of IDL files not matching the actual IDL grammar. One day, I would like to remove this alternative parsing, but as a first step, I want to add a mode I can run preprocess-idls.pl in that uses the real IDL parser to validate that the regex based one is getting the right results.
Sam Weinig
Comment 2 2020-09-06 15:39:16 PDT Comment hidden (obsolete)
Sam Weinig
Comment 3 2020-09-06 15:42:09 PDT
Oh bummer, looks like I can't 'use experimental 'smartmatch';'
Sam Weinig
Comment 4 2020-09-06 16:03:46 PDT Comment hidden (obsolete)
Sam Weinig
Comment 5 2020-09-06 16:05:24 PDT
Created attachment 408149 [details] Patch
EWS
Comment 6 2020-09-06 17:20:05 PDT
Committed r266687: <https://trac.webkit.org/changeset/266687> All reviewed patches have been landed. Closing bug and clearing flags on attachment 408149 [details].
Radar WebKit Bug Importer
Comment 7 2020-09-06 17:21:17 PDT
<rdar://problem/68437813>
Note You need to log in before you can comment on or make changes to this bug.