Bug 216230 - ConvolverNode incorrectly outputs silence because m_reverb is null
Summary: ConvolverNode incorrectly outputs silence because m_reverb is null
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 212611
  Show dependency tree / graph
 
Reported: 2020-09-06 14:21 PDT by Chris Dumez
Modified: 2020-09-06 16:10 PDT (History)
8 users (show)

See Also:

Attachments
Patch (80.35 KB, patch)
2020-09-06 14:27 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (80.94 KB, patch)
2020-09-06 14:55 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-09-06 14:21:24 PDT 
ConvolverNode incorrectly outputs silence because m_reverb is null.
Comment 1 Chris Dumez 2020-09-06 14:27:36 PDT 
Created attachment 408133 [details]
Patch
Comment 2 Darin Adler 2020-09-06 14:32:33 PDT 
Comment on attachment 408133 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408133&action=review

> Source/WebCore/Modules/webaudio/ConvolverNode.h:-63
> -    void initialize() final;
> -    void uninitialize() final;

Can we refactor to get rid of these across the board? Are they valuable?
Comment 3 Chris Dumez 2020-09-06 14:34:12 PDT 
(In reply to Darin Adler from comment #2)
> Comment on attachment 408133 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=408133&action=review
> 
> > Source/WebCore/Modules/webaudio/ConvolverNode.h:-63
> > -    void initialize() final;
> > -    void uninitialize() final;
> 
> Can we refactor to get rid of these across the board? Are they valuable?

Some of them do initialize() / uninitialize() things. I will have to look into it more to see if we can simplify.
Comment 4 Chris Dumez 2020-09-06 14:55:19 PDT 
Created attachment 408135 [details]
Patch
Comment 5 EWS 2020-09-06 16:09:44 PDT 
Committed r266684: <https://trac.webkit.org/changeset/266684>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 408135 [details].
Comment 6 Radar WebKit Bug Importer 2020-09-06 16:10:14 PDT 
<rdar://problem/68436608>