Bug 216226 - Build failure; cannot find seccomp.h
Summary: Build failure; cannot find seccomp.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: All Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-09-06 07:47 PDT by Mike Gorse
Modified: 2020-09-09 15:06 PDT (History)
9 users (show)

See Also:

Attachments
Patch. (1.07 KB, patch)
2020-09-06 09:29 PDT, Mike Gorse 		darin: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch. (1.08 KB, patch)
2020-09-07 07:03 PDT, Mike Gorse 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Gorse 2020-09-06 07:47:05 PDT 
I am getting a build failure with webkitgtk 2.29.92 where g++ cannot find seccomp.h when BubblewrapLauncher.cpp tries to include it. It looks as though LIBSECCOMP_INCLUDE_DIRS just isn't being added to WebKit_SYSTEM_INCLUDE_DIRECTORIES, so I'm not sure why I'm seeing a failure now where I wasn't with 2.28.4.
Comment 1 Mike Gorse 2020-09-06 09:29:58 PDT 
Created attachment 408123 [details]
Patch.
Comment 2 EWS 2020-09-06 14:24:52 PDT 
ChangeLog entry in Source/WebKit/ChangeLog contains OOPS!.
Comment 3 Mike Gorse 2020-09-07 07:03:55 PDT 
Created attachment 408177 [details]
Patch.
Comment 4 Darin Adler 2020-09-07 09:47:14 PDT 
Comment on attachment 408177 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=408177&action=review

> Source/WebKit/ChangeLog:8
> +        No new tests (build fix only).

Next time you contribute a patch like this you are welcome to just delete this line altogether.
Comment 5 EWS 2020-09-07 10:02:45 PDT 
Committed r266702: <https://trac.webkit.org/changeset/266702>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 408177 [details].
Comment 6 Adrian Perez 2020-09-09 15:06:11 PDT 
It would have been nice to convert the CMake find module for libseccomp
to use imported targets while at it… anyway—next time, thanks for writing
the patch, Mike!