There are some bugs :(
Created attachment 408121 [details] Fixes the bugs
Comment on attachment 408121 [details] Fixes the bugs View in context: https://bugs.webkit.org/attachment.cgi?id=408121&action=review > Source/WTF/wtf/CompactUniquePtrTuple.h:69 > + CompactUniquePtrTuple<T, Type, Deleter> moved { WTFMove(other) }; Here inside a member we should not need to repeat the template arguments, so although it can’t use auto, it can be like this: CompactUniquePtrTuple moved { WTFMove(other) }; > Source/WTF/wtf/CompactUniquePtrTuple.h:118 > + template <typename U, typename Y, typename D> friend class CompactUniquePtrTuple; No need for the U/Y/D here. Can just be "typename, typename, typename".
Thanks for the reviews! (In reply to Darin Adler from comment #2) > Comment on attachment 408121 [details] > Fixes the bugs > > View in context: > https://bugs.webkit.org/attachment.cgi?id=408121&action=review > > > Source/WTF/wtf/CompactUniquePtrTuple.h:69 > > + CompactUniquePtrTuple<T, Type, Deleter> moved { WTFMove(other) }; > > Here inside a member we should not need to repeat the template arguments, so > although it can’t use auto, it can be like this: Done. > CompactUniquePtrTuple moved { WTFMove(other) }; > > > Source/WTF/wtf/CompactUniquePtrTuple.h:118 > > + template <typename U, typename Y, typename D> friend class CompactUniquePtrTuple; > > No need for the U/Y/D here. Can just be "typename, typename, typename". Removed.
Committed r266713: <https://trac.webkit.org/changeset/266713>
<rdar://problem/68484458>