Bug 216221 - [LFC][IFC] LineBox should contain all inline boxes
Summary: [LFC][IFC] LineBox should contain all inline boxes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-09-05 21:12 PDT by zalan
Modified: 2020-09-06 14:33 PDT (History)
5 users (show)

See Also:

Attachments
Patch (29.13 KB, patch)
2020-09-05 21:14 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (66.14 KB, patch)
2020-09-06 06:31 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (33.83 KB, patch)
2020-09-06 10:13 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (35.06 KB, patch)
2020-09-06 11:22 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 zalan 2020-09-05 21:14:27 PDT 
Created attachment 408112 [details]
Patch
Comment 2 zalan 2020-09-06 06:31:23 PDT 
Created attachment 408122 [details]
Patch
Comment 3 zalan 2020-09-06 10:13:27 PDT 
Created attachment 408124 [details]
Patch
Comment 4 Antti Koivisto 2020-09-06 10:25:23 PDT 
Comment on attachment 408124 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408124&action=review

> Source/WebCore/ChangeLog:18
> +        In this patch we decouple the line box and the line.
> +        LineBox:
> +        - fully contains all the inline boxes, both horizontally and vertically.
> +        - has only width and height geometry
> +        - height is not constrained by the line-height property
> +        - does not have the concept of overflow.
> +
> +        Line:
> +        - contains the LineBox, but the LineBox can overflow the line, both horizontally and vertically.
> +        - has position relative to the root block container.
> +

Could you clarify in the ChangeLog how this decoupling maps to the code changes in the patch?

> Source/WebCore/layout/inlineformatting/InlineLineBox.h:51
> +// | ----------------------------------|--------------|---------- Root Inline Box
> +// ||   _____    ___      ___          |              |
> +// ||  |        /   \    /   \         |  Inline Box  |
> +// ||  |_____  |     |  |     |        |              |    ascent
> +// ||  |       |     |  |     |        |              |
> +// ||__|________\___/____\___/_________|______________|_______ alignment_baseline

Could you make this FOO larger? I can barely see it.
Comment 5 zalan 2020-09-06 11:22:37 PDT 
Created attachment 408126 [details]
Patch
Comment 6 EWS 2020-09-06 14:32:40 PDT 
Committed r266682: <https://trac.webkit.org/changeset/266682>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 408126 [details].
Comment 7 Radar WebKit Bug Importer 2020-09-06 14:33:17 PDT 
<rdar://problem/68434349>