Bug 216203 - [Cocoa,HDR] HLS streams with HDR variants will not select HDR.
Summary: [Cocoa,HDR] HLS streams with HDR variants will not select HDR.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-09-04 17:02 PDT by Jer Noble
Modified: 2020-09-14 16:18 PDT (History)
13 users (show)

See Also:

Attachments
Patch (1.97 KB, patch)
2020-09-04 17:08 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch for landing (118.48 KB, patch)
2020-09-08 17:29 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch for landing (119.16 KB, patch)
2020-09-11 11:35 PDT, Jer Noble 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch for Landing (119.16 KB, patch)
2020-09-11 12:56 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch for Landing (118.85 KB, patch)
2020-09-14 15:10 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2020-09-04 17:02:18 PDT 
[Cocoa,HDR] HLS streams with HDR variants will not select HDR.
Comment 1 Jer Noble 2020-09-04 17:02:45 PDT 
<rdar://problem/67438626>
Comment 2 Jer Noble 2020-09-04 17:08:26 PDT 
Created attachment 408047 [details]
Patch
Comment 3 Darin Adler 2020-09-04 17:09:51 PDT 
Comment on attachment 408047 [details]
Patch

Regression testing?
Comment 4 Jer Noble 2020-09-04 17:51:36 PDT 
(In reply to Darin Adler from comment #3)
> Comment on attachment 408047 [details]
> Patch
> 
> Regression testing?

It’s hard; I don’t know that we can write a consistent regression test that isn’t flakey here. For one, it’s very hard to determine what variant HLS chooses; AVFoundation goes out of its way to make that difficult. For two, anything we do which _could_ be detectable will perturb HLS’s selection logic. E.g., giving the HDR and SDR variants different sizes would make the selection detectable, but might lead HLS to choose among the smaller or larger variant, rather than the HDR or SDR one. For three, HLS may only switch up to HDR _eventually_, not initially, so the test may end up taking >10s to run, which on the bots means it would be a flakey timeout. I’ll see what I can do; perhaps a stream with very short segment times, like 0.5s each, may make the switching happen quicker.
Comment 5 Jer Noble 2020-09-08 17:29:13 PDT 
Created attachment 408293 [details]
Patch for landing
Comment 6 Jer Noble 2020-09-11 11:35:56 PDT 
Created attachment 408549 [details]
Patch for landing
Comment 7 Jer Noble 2020-09-11 12:56:57 PDT 
Created attachment 408555 [details]
Patch for Landing
Comment 8 EWS 2020-09-14 09:20:54 PDT 
Tools/Scripts/svn-apply failed to apply attachment 408555 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Comment 9 Jer Noble 2020-09-14 15:10:56 PDT 
Created attachment 408749 [details]
Patch for Landing
Comment 10 EWS 2020-09-14 16:17:58 PDT 
Committed r267057: <https://trac.webkit.org/changeset/267057>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 408749 [details].