Bug 216194 - [WebIDL] Realign our IDL extended attribute names with those specified in WebIDL
Summary: [WebIDL] Realign our IDL extended attribute names with those specified in WebIDL
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
: 210762 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-09-04 15:04 PDT by Sam Weinig
Modified: 2020-11-12 09:52 PST (History)
40 users (show)

See Also:

Attachments
Patch (435.68 KB, patch)
2020-09-04 15:16 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (437.44 KB, patch)
2020-09-04 15:23 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (438.01 KB, patch)
2020-09-04 15:31 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (439.34 KB, patch)
2020-09-04 17:21 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (439.16 KB, patch)
2020-09-05 08:44 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (464.89 KB, patch)
2020-09-05 08:53 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2020-09-04 15:04:58 PDT 
[WebIDL] Realign our IDL extended attribute names with those specified in WebIDL
Comment 1 Sam Weinig 2020-09-04 15:16:50 PDT Comment hidden (obsolete)
Comment 2 Sam Weinig 2020-09-04 15:23:56 PDT Comment hidden (obsolete)
Comment 3 Sam Weinig 2020-09-04 15:31:56 PDT Comment hidden (obsolete)
Comment 4 Sam Weinig 2020-09-04 17:21:54 PDT Comment hidden (obsolete)
Comment 5 Sam Weinig 2020-09-05 08:44:34 PDT Comment hidden (obsolete)
Comment 6 Sam Weinig 2020-09-05 08:53:44 PDT 
Created attachment 408087 [details]
Patch
Comment 7 Sam Weinig 2020-09-05 09:02:09 PDT 
This is a big one, but really just renames.
Comment 8 Darin Adler 2020-09-05 09:02:25 PDT 
Comment on attachment 408087 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408087&action=review

Given the “legacy” in LegacyNoInterfaceObject, it’s surprising that it’s so often needed for correct behavior even in relatively new features. Perhaps they erred when naming it?

r=me assuming great EWS results

> Source/WebCore/bindings/js/JSDOMAbstractOperations.h:35
> +enum class LegacyOverrideBuiltIns {

Make this a one-liner? Vertical form not great for a Yes/No.
Comment 9 Sam Weinig 2020-09-05 10:01:46 PDT 
(In reply to Darin Adler from comment #8)
> Comment on attachment 408087 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=408087&action=review
> 
> Given the “legacy” in LegacyNoInterfaceObject, it’s surprising that it’s so
> often needed for correct behavior even in relatively new features. Perhaps
> they erred when naming it?
> 

It has mostly been replaced with the "mixin interface" construct, which we don't support yet (or at least until later today).
Comment 10 EWS 2020-09-05 10:14:30 PDT 
Committed r266662: <https://trac.webkit.org/changeset/266662>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 408087 [details].
Comment 11 Radar WebKit Bug Importer 2020-09-05 10:15:20 PDT 
<rdar://problem/68399022>
Comment 12 Sam Weinig 2020-09-05 14:38:51 PDT 
(In reply to Darin Adler from comment #8)
> > Source/WebCore/bindings/js/JSDOMAbstractOperations.h:35
> > +enum class LegacyOverrideBuiltIns {
> 
> Make this a one-liner? Vertical form not great for a Yes/No.

Neglected to do this in the commit. Fix up for review at https://bugs.webkit.org/show_bug.cgi?id=216218.
Comment 13 Alexey Shvayka 2020-11-12 09:52:09 PST 
*** Bug 210762 has been marked as a duplicate of this bug. ***