RESOLVED FIXED 216181
[WebXR] Implement XRSession end event 
https://bugs.webkit.org/show_bug.cgi?id=216181
Summary [WebXR] Implement XRSession end event
Sergio Villar Senin
Reported 2020-09-04 09:23:02 PDT
[WebXR] Implement XRSession end event
Attachments
Patch (7.26 KB, patch)
2020-09-04 09:35 PDT, Sergio Villar Senin 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sergio Villar Senin
Comment 1 2020-09-04 09:35:54 PDT
Created attachment 407984 [details] Patch
Darin Adler
Comment 2 2020-09-05 09:11:36 PDT
Comment on attachment 407984 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407984&action=review > Source/WebCore/Modules/webxr/XRSessionEvent.h:39 > + static Ref<XRSessionEvent> create(const AtomString&, RefPtr<WebXRSession>&&); In new code I suggest we start using the Init structures in our C++ code instead of having multiple constructors and create functions in all our event classes. I tried his and it seemed to come out pretty good but the patch to do it across the board is huge.
Sergio Villar Senin
Comment 3 2020-09-09 08:48:15 PDT
Comment on attachment 407984 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407984&action=review >> Source/WebCore/Modules/webxr/XRSessionEvent.h:39 >> + static Ref<XRSessionEvent> create(const AtomString&, RefPtr<WebXRSession>&&); > > In new code I suggest we start using the Init structures in our C++ code instead of having multiple constructors and create functions in all our event classes. I tried his and it seemed to come out pretty good but the patch to do it across the board is huge. OK, I'll replace it before landing.
Sergio Villar Senin
Comment 4 2020-09-09 09:00:35 PDT
Committed r266782: <https://trac.webkit.org/changeset/266782>
Radar WebKit Bug Importer
Comment 5 2020-09-09 09:01:20 PDT
<rdar://problem/68575993>
Note You need to log in before you can comment on or make changes to this bug.