Bug 216181 - [WebXR] Implement XRSession end event
Summary: [WebXR] Implement XRSession end event
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sergio Villar Senin
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-09-04 09:23 PDT by Sergio Villar Senin
Modified: 2020-09-09 09:01 PDT (History)
8 users (show)

See Also:

Attachments
Patch (7.26 KB, patch)
2020-09-04 09:35 PDT, Sergio Villar Senin 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sergio Villar Senin 2020-09-04 09:23:02 PDT 
[WebXR] Implement XRSession end event
Comment 1 Sergio Villar Senin 2020-09-04 09:35:54 PDT 
Created attachment 407984 [details]
Patch
Comment 2 Darin Adler 2020-09-05 09:11:36 PDT 
Comment on attachment 407984 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407984&action=review

> Source/WebCore/Modules/webxr/XRSessionEvent.h:39
> +    static Ref<XRSessionEvent> create(const AtomString&, RefPtr<WebXRSession>&&);

In new code I suggest we start using the Init structures in our C++ code instead of having multiple constructors and create functions in all our event classes. I tried his and it seemed to come out pretty good but the patch to do it across the board is huge.
Comment 3 Sergio Villar Senin 2020-09-09 08:48:15 PDT 
Comment on attachment 407984 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407984&action=review

>> Source/WebCore/Modules/webxr/XRSessionEvent.h:39
>> +    static Ref<XRSessionEvent> create(const AtomString&, RefPtr<WebXRSession>&&);
> 
> In new code I suggest we start using the Init structures in our C++ code instead of having multiple constructors and create functions in all our event classes. I tried his and it seemed to come out pretty good but the patch to do it across the board is huge.

OK, I'll replace it before landing.
Comment 4 Sergio Villar Senin 2020-09-09 09:00:35 PDT 
Committed r266782: <https://trac.webkit.org/changeset/266782>
Comment 5 Radar WebKit Bug Importer 2020-09-09 09:01:20 PDT 
<rdar://problem/68575993>