"Ensure that element of role \u0022%s\u0022 and \u0022%s\u0022 have required owned elements in accordance with WAI-ARIA." should be more akin to "Ensure that elements of role \u0022%s\u0022 and \u0022%s\u0022 have required owned elements in accordance with WAI-ARIA."
<rdar://63757787>
Created attachment 407976 [details] Patch
Comment on attachment 407976 [details] Patch r=me
Committed r266612: <https://trac.webkit.org/changeset/266612> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407976 [details].
Comment on attachment 407976 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407976&action=review > Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:536 > -localizedStrings["Ensure that element of role \u0022%s\u0022 and \u0022%s\u0022 have required owned elements in accordance with WAI-ARIA."] = "Ensure that element of role \u0022%s\u0022 and \u0022%s\u0022 have required owned elements in accordance with WAI-ARIA."; > -localizedStrings["Ensure that element of role \u0022%s\u0022 have required owned elements in accordance with WAI-ARIA."] = "Ensure that element of role \u0022%s\u0022 have required owned elements in accordance with WAI-ARIA."; > +localizedStrings["Ensure that element of role \u0022%s\u0022 and \u0022%s\u0022 has required owned elements in accordance with WAI-ARIA."] = "Ensure that element of role \u0022%s\u0022 and \u0022%s\u0022 has required owned elements in accordance with WAI-ARIA."; > +localizedStrings["Ensure that element of role \u0022%s\u0022 has required owned elements in accordance with WAI-ARIA."] = "Ensure that element of role \u0022%s\u0022 has required owned elements in accordance with WAI-ARIA."; I think these changes are in the wrong direction. Both of these audits check multiple elements for the required state, and as such the string should really read "Ensure that elements of role \u0022%s\u0022 have required owned elements ...". So plural "elements" and "have", not singular. This also matches what the other tests do.
Comment on attachment 407976 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407976&action=review >> Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:536 >> +localizedStrings["Ensure that element of role \u0022%s\u0022 has required owned elements in accordance with WAI-ARIA."] = "Ensure that element of role \u0022%s\u0022 has required owned elements in accordance with WAI-ARIA."; > > I think these changes are in the wrong direction. Both of these audits check multiple elements for the required state, and as such the string should really read "Ensure that elements of role \u0022%s\u0022 have required owned elements ...". So plural "elements" and "have", not singular. This also matches what the other tests do. Looking at this again I think you are right. I even said so in my problem description, and proceeded in the opposite direction...
Reopening to attach new patch.
Created attachment 407996 [details] Patch
Created attachment 407997 [details] Patch
Comment on attachment 407997 [details] Patch r=me
Committed r266624: <https://trac.webkit.org/changeset/266624> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407997 [details].