Bug 216176 – Web Inspector: Localization: typo in WAI-ARIA string ("[the] element have")

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Patrick Angle]

"Ensure that element of role \u0022%s\u0022 and \u0022%s\u0022 have required owned elements in accordance with WAI-ARIA." should be more akin to "Ensure that elements of role \u0022%s\u0022 and \u0022%s\u0022 have required owned elements in accordance with WAI-ARIA."

[Patrick Angle]

<rdar://63757787>

[Patrick Angle]

Created attachment 407976 [details]
Patch

[Blaze Burg]

Comment on attachment 407976 [details]
Patch

r=me

[EWS]

Committed r266612: <https://trac.webkit.org/changeset/266612>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 407976 [details].

[Devin Rousso]

Comment on attachment 407976 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407976&action=review

> Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:536
> -localizedStrings["Ensure that element of role \u0022%s\u0022 and \u0022%s\u0022 have required owned elements in accordance with WAI-ARIA."] = "Ensure that element of role \u0022%s\u0022 and \u0022%s\u0022 have required owned elements in accordance with WAI-ARIA.";
> -localizedStrings["Ensure that element of role \u0022%s\u0022 have required owned elements in accordance with WAI-ARIA."] = "Ensure that element of role \u0022%s\u0022 have required owned elements in accordance with WAI-ARIA.";
> +localizedStrings["Ensure that element of role \u0022%s\u0022 and \u0022%s\u0022 has required owned elements in accordance with WAI-ARIA."] = "Ensure that element of role \u0022%s\u0022 and \u0022%s\u0022 has required owned elements in accordance with WAI-ARIA.";
> +localizedStrings["Ensure that element of role \u0022%s\u0022 has required owned elements in accordance with WAI-ARIA."] = "Ensure that element of role \u0022%s\u0022 has required owned elements in accordance with WAI-ARIA.";

I think these changes are in the wrong direction.  Both of these audits check multiple elements for the required state, and as such the string should really read "Ensure that elements of role \u0022%s\u0022 have required owned elements ...".  So plural "elements" and "have", not singular.  This also matches what the other tests do.

[Patrick Angle]

Comment on attachment 407976 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407976&action=review

>> Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:536
>> +localizedStrings["Ensure that element of role \u0022%s\u0022 has required owned elements in accordance with WAI-ARIA."] = "Ensure that element of role \u0022%s\u0022 has required owned elements in accordance with WAI-ARIA.";
> 
> I think these changes are in the wrong direction.  Both of these audits check multiple elements for the required state, and as such the string should really read "Ensure that elements of role \u0022%s\u0022 have required owned elements ...".  So plural "elements" and "have", not singular.  This also matches what the other tests do.

Looking at this again I think you are right. I even said so in my problem description, and proceeded in the opposite direction...

[Patrick Angle]

Reopening to attach new patch.

[Patrick Angle]

Created attachment 407996 [details]
Patch

[Patrick Angle]

Created attachment 407997 [details]
Patch

[Devin Rousso]

Comment on attachment 407997 [details]
Patch

r=me

[EWS]

Committed r266624: <https://trac.webkit.org/changeset/266624>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 407997 [details].