Bug 216175 - [macOS] Add client decoder entitlement
Summary: [macOS] Add client decoder entitlement
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-09-04 07:56 PDT by Per Arne Vollan
Modified: 2020-09-04 09:36 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.43 KB, patch)
2020-09-04 08:00 PDT, Per Arne Vollan 		bfulgham: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2020-09-04 07:56:27 PDT 
Add client decoder entitlement on macOS.
Comment 1 Per Arne Vollan 2020-09-04 07:59:50 PDT 
<rdar://problem/67532128>
Comment 2 Per Arne Vollan 2020-09-04 08:00:24 PDT 
Created attachment 407971 [details]
Patch
Comment 3 Brent Fulgham 2020-09-04 09:11:00 PDT 
Comment on attachment 407971 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407971&action=review

r=me

> Source/WebKit/Scripts/process-entitlements.sh:22
> +            plistbuddy Add :com.apple.developer.coremedia.allow-client-decoder-sandbox bool YES

I think this label might change, but maybe we want to use this now to get some benchmark data?
Comment 4 Per Arne Vollan 2020-09-04 09:33:34 PDT 
(In reply to Brent Fulgham from comment #3)
> Comment on attachment 407971 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=407971&action=review
> 
> r=me
> 
> > Source/WebKit/Scripts/process-entitlements.sh:22
> > +            plistbuddy Add :com.apple.developer.coremedia.allow-client-decoder-sandbox bool YES
> 
> I think this label might change, but maybe we want to use this now to get
> some benchmark data?

Yes, I believe that is the plan.

Thanks for reviewing!
Comment 5 Per Arne Vollan 2020-09-04 09:36:33 PDT 
Landed <https://trac.webkit.org/changeset/266613/webkit>.