WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
216171
[GStreamer] REGRESSION(
r266559
): imported/w3c/web-platform-tests/webaudio/the-audio-api/the-destinationnode-interface/destination.html is failing
https://bugs.webkit.org/show_bug.cgi?id=216171
Summary
[GStreamer] REGRESSION(r266559): imported/w3c/web-platform-tests/webaudio/the...
Diego Pino
Reported
2020-09-04 01:26:34 PDT
The test started failing after
r266559
(AudioDestinationNode.maxChannelCount always returns 0): imported/w3c/web-platform-tests/webaudio/the-audio-api/the-destinationnode-interface/destination.html [ Failure ] Diff:
https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r266579%20(15632)/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-destinationnode-interface/destination-diff.txt
--- /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-destinationnode-interface/destination-expected.txt +++ /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-destinationnode-interface/destination-actual.txt @@ -1,5 +1,5 @@ -PASS +FAIL AudioDestinationNode - + assert_greater_than_equal: maxChannelCount should be >= 2 expected a number greater than or equal to 2 but got 0
Attachments
Patch
(35.30 KB, patch)
2020-10-19 05:30 PDT
,
Philippe Normand
no flags
Details
Formatted Diff
Diff
Patch
(34.67 KB, patch)
2020-10-20 01:31 PDT
,
Philippe Normand
no flags
Details
Formatted Diff
Diff
Patch
(34.66 KB, patch)
2020-10-20 02:19 PDT
,
Philippe Normand
calvaris
: review+
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Philippe Normand
Comment 1
2020-09-04 01:52:02 PDT
To fix this I suppose we should look for Audio/Sink GstDevices and check the channels range in the caps...
Philippe Normand
Comment 2
2020-10-19 05:30:25 PDT
Created
attachment 411739
[details]
Patch
Philippe Normand
Comment 3
2020-10-19 05:30:53 PDT
***
Bug 217699
has been marked as a duplicate of this bug. ***
Peng Liu
Comment 4
2020-10-19 11:59:57 PDT
Comment on
attachment 411739
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=411739&action=review
> Source/WebCore/platform/audio/gstreamer/AudioDestinationGStreamer.cpp:103 > + WTFLogAlways("AudioDestination::create(%u, %u, %f) - unhandled input channels", numberOfInputChannels, numberOfOutputChannels, sampleRate);
Nit. Is this change intended?
> Source/WebCore/platform/audio/gstreamer/AudioDestinationGStreamer.cpp:207 > + // m_isPlaying = newState >= GST_STATE_PLAYING;
Nit. Is this comment useful?
> Source/WebCore/platform/audio/gstreamer/AudioSourceProviderGStreamer.cpp:266 > + [](GstAppSink* sink, gpointer userData) -> GstFlowReturn {
Looks like a duplicated code block? Can we avoid it? Thanks!
Philippe Normand
Comment 5
2020-10-20 01:31:15 PDT
Created
attachment 411848
[details]
Patch
Philippe Normand
Comment 6
2020-10-20 02:19:29 PDT
Created
attachment 411850
[details]
Patch
Xabier Rodríguez Calvar
Comment 7
2020-10-20 03:01:34 PDT
Comment on
attachment 411850
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=411850&action=review
> Source/WebCore/platform/audio/gstreamer/AudioDestinationGStreamer.cpp:103 > + WTFLogAlways("AudioDestination::create(%u, %u, %f) - unhandled input channels", numberOfInputChannels, numberOfOutputChannels, sampleRate);
As Peng Liu asked, is the change to always intentional?
Philippe Normand
Comment 8
2020-10-20 03:03:44 PDT
Comment on
attachment 411850
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=411850&action=review
>> Source/WebCore/platform/audio/gstreamer/AudioDestinationGStreamer.cpp:103 >> + WTFLogAlways("AudioDestination::create(%u, %u, %f) - unhandled input channels", numberOfInputChannels, numberOfOutputChannels, sampleRate); > > As Peng Liu asked, is the change to always intentional?
Yes, it's matching the cocoa implementation.
Philippe Normand
Comment 9
2020-10-20 06:20:10 PDT
Committed
r268727
: <
https://trac.webkit.org/changeset/268727
>
Radar WebKit Bug Importer
Comment 10
2020-10-20 06:21:15 PDT
<
rdar://problem/70482643
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug