Bug 216152 - Tests using OscillatorNode are flaky
Summary: Tests using OscillatorNode are flaky
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 212611
  Show dependency tree / graph
 
Reported: 2020-09-03 16:21 PDT by Chris Dumez
Modified: 2020-09-03 19:01 PDT (History)
10 users (show)

See Also:

Attachments
Patch (27.22 KB, patch)
2020-09-03 17:00 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (27.22 KB, patch)
2020-09-03 17:05 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (27.22 KB, patch)
2020-09-03 17:22 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (25.23 KB, patch)
2020-09-03 18:14 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-09-03 16:21:11 PDT 
Tests using OscillatorNode are flaky.
Comment 1 Chris Dumez 2020-09-03 17:00:47 PDT 
Created attachment 407931 [details]
Patch
Comment 2 Chris Dumez 2020-09-03 17:05:36 PDT 
Created attachment 407932 [details]
Patch
Comment 3 Darin Adler 2020-09-03 17:06:38 PDT 
Comment on attachment 407931 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407931&action=review

> Source/WebCore/Modules/webaudio/BaseAudioContext.h:466
> +    // These are cached per audio context for performance reason. They cannot be

"reason" -> "reasons"
Comment 4 Chris Dumez 2020-09-03 17:22:11 PDT 
Created attachment 407934 [details]
Patch
Comment 5 Chris Dumez 2020-09-03 18:14:10 PDT 
Created attachment 407938 [details]
Patch
Comment 6 EWS 2020-09-03 19:00:05 PDT 
Committed r266570: <https://trac.webkit.org/changeset/266570>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 407938 [details].
Comment 7 Radar WebKit Bug Importer 2020-09-03 19:01:16 PDT 
<rdar://problem/68316059>