Bug 216148 - [WebIDL] Replace 'serializable' with '[Default] object toJSON()'
Summary: [WebIDL] Replace 'serializable' with '[Default] object toJSON()'
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-09-03 15:26 PDT by Sam Weinig
Modified: 2020-09-14 10:21 PDT (History)
17 users (show)

See Also:


Attachments
Patch (84.38 KB, patch)
2020-09-03 15:27 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff
Patch (116.49 KB, patch)
2020-09-03 17:00 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff
Patch (116.52 KB, patch)
2020-09-04 09:22 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff
Patch (117.11 KB, patch)
2020-09-04 11:23 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff
Patch (117.11 KB, patch)
2020-09-04 11:25 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff
Patch (117.91 KB, patch)
2020-09-04 13:28 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff
Patch (328.65 KB, patch)
2020-09-04 13:52 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff
Patch (328.90 KB, patch)
2020-09-04 15:18 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff
Patch (330.65 KB, patch)
2020-09-13 20:12 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff
Patch (338.41 KB, patch)
2020-09-13 21:11 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff
Patch (338.42 KB, patch)
2020-09-14 09:49 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2020-09-03 15:26:33 PDT
[WebIDL] Replace 'serializable' with '[Default] object toJSON()'
Comment 1 Sam Weinig 2020-09-03 15:27:18 PDT Comment hidden (obsolete)
Comment 2 Sam Weinig 2020-09-03 17:00:26 PDT Comment hidden (obsolete)
Comment 3 Sam Weinig 2020-09-04 09:22:45 PDT Comment hidden (obsolete)
Comment 4 Sam Weinig 2020-09-04 11:23:35 PDT Comment hidden (obsolete)
Comment 5 Sam Weinig 2020-09-04 11:25:58 PDT Comment hidden (obsolete)
Comment 6 Sam Weinig 2020-09-04 13:28:00 PDT Comment hidden (obsolete)
Comment 7 Sam Weinig 2020-09-04 13:52:35 PDT Comment hidden (obsolete)
Comment 8 Sam Weinig 2020-09-04 15:18:35 PDT Comment hidden (obsolete)
Comment 9 Radar WebKit Bug Importer 2020-09-10 15:27:32 PDT
<rdar://problem/68668407>
Comment 10 Sam Weinig 2020-09-13 20:12:09 PDT
Created attachment 408675 [details]
Patch
Comment 11 Sam Weinig 2020-09-13 21:11:53 PDT
Created attachment 408679 [details]
Patch
Comment 12 Eric Carlson 2020-09-14 08:12:28 PDT
Comment on attachment 408679 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408679&action=review

r=me

> Source/WebCore/ChangeLog:13
> +        result. Rather, all attributes that quality as have a 'JSON type' are included

"attributes that quality as have a 'JSON type'" isn't quite right, maybe "attributes that qualify have a 'JSON type'" or "attributes that have a 'JSON type'"
Comment 13 Sam Weinig 2020-09-14 09:49:29 PDT
Created attachment 408717 [details]
Patch
Comment 14 EWS 2020-09-14 10:21:54 PDT
Committed r267020: <https://trac.webkit.org/changeset/267020>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 408717 [details].