Bug 216133 - Web Inspector: Timelines: record button disappears when UI is narrow
Summary: Web Inspector: Timelines: record button disappears when UI is narrow
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-09-03 11:18 PDT by Nikita Vasilyev
Modified: 2020-09-03 12:17 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.11 KB, patch)
2020-09-03 11:21 PDT, Nikita Vasilyev 		hi: review+
Details | Formatted Diff | Diff
[Video] With patch applied (515.41 KB, video/quicktime)
2020-09-03 11:23 PDT, Nikita Vasilyev 		no flags Details
Patch (978 bytes, patch)
2020-09-03 11:31 PDT, Nikita Vasilyev 		nvasilyev: review-
nvasilyev: commit-queue-
Details | Formatted Diff | Diff
Patch (2.46 KB, patch)
2020-09-03 11:31 PDT, Nikita Vasilyev 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2020-09-03 11:18:43 PDT 
<rdar://55875921>
Comment 1 Nikita Vasilyev 2020-09-03 11:21:43 PDT 
Created attachment 407896 [details]
Patch
Comment 2 Nikita Vasilyev 2020-09-03 11:23:18 PDT 
Created attachment 407898 [details]
[Video] With patch applied
Comment 3 Devin Rousso 2020-09-03 11:28:21 PDT 
Comment on attachment 407896 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407896&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/TimelineTabContentView.js:49
> +        this._recordButton.visibilityPriority = WI.NavigationItem.VisibilityPriority.High;

we should also do this to `_continueButton`, as it's shown instead of `_recordButton` when ⌥ is pressed and the active recording will auto-stop (`WI.TimelineTabContentView.prototype._updateNavigationBarButtons`)
Comment 4 Nikita Vasilyev 2020-09-03 11:31:12 PDT Comment hidden (obsolete)
Comment 5 Nikita Vasilyev 2020-09-03 11:31:54 PDT 
Created attachment 407900 [details]
Patch
Comment 6 EWS 2020-09-03 12:17:05 PDT 
Committed r266537: <https://trac.webkit.org/changeset/266537>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 407900 [details].