Bug 216132 - Make AudioParam.cancelScheduledValues() standards compliant
Summary: Make AudioParam.cancelScheduledValues() standards compliant
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 212611
  Show dependency tree / graph
 
Reported: 2020-09-03 11:10 PDT by Chris Dumez
Modified: 2020-09-03 14:43 PDT (History)
10 users (show)

See Also:

Attachments
Patch (5.43 KB, patch)
2020-09-03 11:16 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (5.57 KB, patch)
2020-09-03 14:30 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-09-03 11:10:44 PDT 
Make AudioParam.cancelScheduledValues() standards compliant.
Comment 1 Chris Dumez 2020-09-03 11:16:35 PDT 
Created attachment 407895 [details]
Patch
Comment 2 Geoffrey Garen 2020-09-03 13:04:30 PDT 
Comment on attachment 407895 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407895&action=review

r=me

> Source/WebCore/Modules/webaudio/AudioParamTimeline.cpp:165
> +        if (eventTime >= cancelTime || ((m_events[i].type() == ParamEvent::SetValueCurve)
> +            && eventTime <= cancelTime && (eventTime + m_events[i].duration() > cancelTime))) {

This condition clause might read more easily as a helper lambda called as "isAfter(m_events[I], cancelTime)".
Comment 3 Chris Dumez 2020-09-03 14:30:08 PDT 
Created attachment 407912 [details]
Patch
Comment 4 Chris Dumez 2020-09-03 14:42:49 PDT 
Comment on attachment 407912 [details]
Patch

Clearing flags on attachment: 407912

Committed r266558: <https://trac.webkit.org/changeset/266558>
Comment 5 Chris Dumez 2020-09-03 14:42:52 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2020-09-03 14:43:13 PDT 
<rdar://problem/68302775>