Bug 216099 - Choose adequate number of channels for ConvolverNode's output
Summary: Choose adequate number of channels for ConvolverNode's output
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 212611
  Show dependency tree / graph
 
Reported: 2020-09-02 14:47 PDT by Chris Dumez
Modified: 2020-09-02 20:23 PDT (History)
10 users (show)

See Also:

Attachments
Patch (87.03 KB, patch)
2020-09-02 15:06 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (86.96 KB, patch)
2020-09-02 16:00 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (86.96 KB, patch)
2020-09-02 16:03 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (104.39 KB, patch)
2020-09-02 17:15 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (104.51 KB, patch)
2020-09-02 17:22 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-09-02 14:47:04 PDT 
Choose adequate number of channel for ConvolverNode's output. We were using 2 channels for the output no matter what but we're supposed to use a single channel if the both input  and the response buffer are mono.
Comment 1 Chris Dumez 2020-09-02 15:06:20 PDT 
Created attachment 407820 [details]
Patch
Comment 2 Eric Carlson 2020-09-02 15:56:36 PDT 
Comment on attachment 407820 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407820&action=review

> Source/WebCore/ChangeLog:9
> +        the output no matter what but we're supposed to use a single channel if the both input 

s/if the both/if both the/
Comment 3 Chris Dumez 2020-09-02 16:00:24 PDT 
Created attachment 407826 [details]
Patch
Comment 4 Chris Dumez 2020-09-02 16:03:35 PDT 
Created attachment 407827 [details]
Patch
Comment 5 Chris Dumez 2020-09-02 17:15:59 PDT 
Created attachment 407835 [details]
Patch
Comment 6 Chris Dumez 2020-09-02 17:22:06 PDT 
Created attachment 407836 [details]
Patch
Comment 7 EWS 2020-09-02 20:22:34 PDT 
Committed r266501: <https://trac.webkit.org/changeset/266501>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 407836 [details].
Comment 8 Radar WebKit Bug Importer 2020-09-02 20:23:31 PDT 
<rdar://problem/68251440>