Bug 216097 – Simplify some editing code

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Darin Adler]

Simplify some editing code

[Darin Adler]

Created attachment 407810 [details]
Patch

[Darin Adler]

Came from one of the things Sam Weinig asked for in my last patch.

[EWS]

Committed r266498: <https://trac.webkit.org/changeset/266498>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 407810 [details].

[Radar WebKit Bug Importer]

<rdar://problem/68246474>

[Truitt Savell]

It looks like the changes in https://trac.webkit.org/changeset/266498/webkit

has caused editing/inserting/insert-paragraph-separator-crash.html

to crash constantly with an assertion on Mac and iOS debug

History:
https://results.webkit.org/?suite=layout-tests&test=editing%2Finserting%2Finsert-paragraph-separator-crash.html

Log:
https://build.webkit.org/results/Apple-Catalina-Debug-WK1-Tests/r266517%20(6843)/editing/inserting/insert-paragraph-separator-crash-crash-log.txt

[Truitt Savell]

Created https://bugs.webkit.org/show_bug.cgi?id=216128 to track this

[Darin Adler]

Lets roll this out. I will re-land after fixing.

[WebKit Commit Bot]

Re-opened since this is blocked by bug 216143

[Darin Adler]

Comment on attachment 407810 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407810&action=review

> Source/WebCore/page/DOMSelection.cpp:344
> +    frame->selection().setSelectedRange(makeSimpleRange(selectedRange->start), Affinity::Upstream, FrameSelection::ShouldCloseTyping::No);

Turns out this needs to be Affinity::Downstream to preserve behavior. Might be correct to have it be upstream, but requires changes elsewhere. Landing with Affinity::Downstream to preserve behavior.

[Darin Adler]

Committed r266618: <https://trac.webkit.org/changeset/266618>