Bug 216094 - Align ISO-8859-{3,6,7,8} and windows-{874,1253} encodings with Chrome, Firefox, and the specification
Summary: Align ISO-8859-{3,6,7,8} and windows-{874,1253} encodings with Chrome, Firefo...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-09-02 13:53 PDT by Alex Christensen
Modified: 2020-09-03 09:35 PDT (History)
7 users (show)

See Also:

Attachments
Patch (112.38 KB, patch)
2020-09-02 13:55 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (112.61 KB, patch)
2020-09-02 14:12 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (154.47 KB, patch)
2020-09-02 15:20 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (155.37 KB, patch)
2020-09-02 16:45 PDT, Alex Christensen 		darin: review+
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2020-09-02 13:53:04 PDT 
Align ISO-8859-{3,6,7,8} and windows-{874,1253} encodings with Chrome, Firefox, and the specification
Comment 1 Alex Christensen 2020-09-02 13:55:42 PDT 
Created attachment 407802 [details]
Patch
Comment 2 Alex Christensen 2020-09-02 14:12:22 PDT 
Created attachment 407808 [details]
Patch
Comment 3 Alex Christensen 2020-09-02 15:20:08 PDT 
Created attachment 407821 [details]
Patch
Comment 4 Peng Liu 2020-09-02 15:48:47 PDT 
Comment on attachment 407821 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407821&action=review

> Source/WebCore/platform/text/TextCodecSingleByte.cpp:36
> +const UChar iso88593[128] {

Use constexpr like others?
Comment 5 Alex Christensen 2020-09-02 16:45:34 PDT 
Created attachment 407832 [details]
Patch
Comment 6 Alex Christensen 2020-09-03 09:22:34 PDT 
Looks like I need to update fast/encoding/char-decoding.html also.  Will do.
Comment 7 Alex Christensen 2020-09-03 09:29:58 PDT 
Comment on attachment 407832 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407832&action=review

> Source/WTF/wtf/PlatformHave.h:740
> +#define HAVE_ICU_WITH_CORRECT_WINDOWS_1255 1

This was optimistic. Big Sur and iOS14 have an ICU that is more correct but not completely correct.  I'll remove this and just use the table everywhere.
Comment 8 Alex Christensen 2020-09-03 09:34:16 PDT 
http://trac.webkit.org/r266527
Comment 9 Radar WebKit Bug Importer 2020-09-03 09:35:18 PDT 
<rdar://problem/68284106>