Bug 216091 - Fix rounding for DelayDSPKernel's buffer size calculation
Summary: Fix rounding for DelayDSPKernel's buffer size calculation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 212611
  Show dependency tree / graph
 
Reported: 2020-09-02 12:53 PDT by Chris Dumez
Modified: 2020-09-02 15:08 PDT (History)
10 users (show)

See Also:

Attachments
Patch (4.23 KB, patch)
2020-09-02 12:55 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-09-02 12:53:50 PDT 
Fix rounding for DelayDSPKernel's buffer size calculation. The DelayNode needs to buffer |maxDelayTime| sample frames, plus one frame for interpolation. If |maxDelayTime| isn't an integer, we have to round it up or the buffer would end up one frame short.
Comment 1 Chris Dumez 2020-09-02 12:55:08 PDT 
Created attachment 407789 [details]
Patch
Comment 2 Geoffrey Garen 2020-09-02 12:58:57 PDT 
Comment on attachment 407789 [details]
Patch

r=me
Comment 3 Chris Dumez 2020-09-02 15:07:30 PDT 
Comment on attachment 407789 [details]
Patch

Clearing flags on attachment: 407789

Committed r266491: <https://trac.webkit.org/changeset/266491>
Comment 4 Chris Dumez 2020-09-02 15:07:32 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2020-09-02 15:08:16 PDT 
<rdar://problem/68235721>