Bug 216072 - Expose RTCPeerConnection.restartIce
Summary: Expose RTCPeerConnection.restartIce
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-09-02 05:44 PDT by youenn fablet
Modified: 2020-09-03 06:25 PDT (History)
14 users (show)

See Also:

Attachments
Patch (11.63 KB, patch)
2020-09-02 05:45 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (12.64 KB, patch)
2020-09-02 05:49 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (16.71 KB, patch)
2020-09-02 08:40 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2020-09-02 05:44:36 PDT 
Expose RTCPeerConnection.restartIce
Comment 1 youenn fablet 2020-09-02 05:45:48 PDT 
Created attachment 407759 [details]
Patch
Comment 2 youenn fablet 2020-09-02 05:49:08 PDT 
Created attachment 407760 [details]
Patch
Comment 3 youenn fablet 2020-09-02 08:40:37 PDT 
Created attachment 407769 [details]
Patch
Comment 4 Darin Adler 2020-09-02 10:04:51 PDT 
Comment on attachment 407769 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407769&action=review

> Source/WebCore/Modules/mediastream/RTCPeerConnection.h:127
> +    void restartIce() { m_backend->restartIce(); }

No null check needed here?
Comment 5 youenn fablet 2020-09-02 10:11:09 PDT 
(In reply to Darin Adler from comment #4)
> Comment on attachment 407769 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=407769&action=review
> 
> > Source/WebCore/Modules/mediastream/RTCPeerConnection.h:127
> > +    void restartIce() { m_backend->restartIce(); }
> 
> No null check needed here?

The model is a bit weird right now so we cannot have a UniqueRef, as we would probably like.
Basically RTCPeerConnection constructor creates the backend and RTCPeerConnection::create makes sure a peer connection has a backend, or it throws and deallocate the RTCPeerConnection.

I can probably refactor this to use a UniqueRef and clarify this.
Comment 6 EWS 2020-09-03 06:24:38 PDT 
Committed r266511: <https://trac.webkit.org/changeset/266511>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 407769 [details].
Comment 7 Radar WebKit Bug Importer 2020-09-03 06:25:32 PDT 
<rdar://problem/68275102>