Bug 21606 – need consistency in naming of collection getters

• Status: RESOLVED
• Resolution: WONTFIX
• Component: WebCore JavaScript

[Ojan Vafai]

<weinig> after briefly talking this over with maciej, we actually think that using a name other than namedItem would be better
<weinig> instead, I would recommend adding a nameGetter method to all the DOM classes that require special name lookup
<weinig> for things like NodeList, it could be an inline function that just calls namedItem

[Ojan Vafai]

from webkit-dev:
It would be great to make things as consistently as possible, though the key here is "as possible". Some of the IDL interfaces define an explicit namedItem() or getNamedItem() function, while others have only an implicit name getter. It is even possible in theory for an interface to have only a method named namedItem() but no implicit get-by-name behavior.

What I would suggest is to give every class that supports get-by-name a method called "namedGetter", which is just an inline call to namedItem or getNamedItem or whatever, if there is an appropriate such method. Then the bindings generator could be changed so it can make use of that, and not require you to write namedItem() by hand in the JS bindings (by this I mean the JSC JS bindings).

Regards,
Maciej

[Ojan Vafai]

All the IDL cases where nameGetter were used that Chromium relied on have been changed to namedItem as they were exposed as such in Firefox. I don't have the bug IDs on hand, but in either case, I think this is no longer worth doing.