Bug 216057 - Web Inspector: Timelines: re-enabling the JavaScript Allocations timeline doesn't show previously captured heap snapshots in the table
Summary: Web Inspector: Timelines: re-enabling the JavaScript Allocations timeline doe...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-09-01 16:07 PDT by Devin Rousso
Modified: 2020-09-02 08:48 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.89 KB, patch)
2020-09-01 18:18 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2020-09-01 16:07:02 PDT 
# STEPS TO REPRODUCE
1. inspect <https://webkit.org/>
2. go to the Timelines Tab
3. enable the JavaScript Allocations timeline instrument
4. reload the page to capture some heap snapshots (should have at least two)
5. enter Edit mode
6. disable the JavaScript Allocations timeline instrument
7. exit Edit mode
8. enter Edit mode
9. enable the JavaScript Allocations timeline instrument
10. exit Edit mode

# EXPECTED
The JavaScript Allocations timeline instrument should show either the previously captured heap snapshots or no heap snapshots (i.e. they were cleared when the JavaScript Allocations timeline instrument was disabled).

# ACTUAL
The overview graph shows records for each previously captured heap snapshot, but the JavaScript Allocations table has no rows and clicking on any of the heap snapshot records in the overview graph does nothing.
Comment 1 Radar WebKit Bug Importer 2020-09-01 16:07:15 PDT 
<rdar://problem/68172848>
Comment 2 Devin Rousso 2020-09-01 18:18:56 PDT 
Created attachment 407727 [details]
Patch
Comment 3 BJ Burg 2020-09-02 08:45:58 PDT 
Comment on attachment 407727 [details]
Patch

r=me
Comment 4 EWS 2020-09-02 08:48:31 PDT 
Committed r266463: <https://trac.webkit.org/changeset/266463>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 407727 [details].