Bug 216050 - Make sure BiquadFilterNode tail is getting processed
Summary: Make sure BiquadFilterNode tail is getting processed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 212611
  Show dependency tree / graph
 
Reported: 2020-09-01 14:00 PDT by Chris Dumez
Modified: 2020-09-01 16:12 PDT (History)
10 users (show)

See Also:

Attachments
Patch (35.37 KB, patch)
2020-09-01 14:05 PDT, Chris Dumez 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-09-01 14:00:53 PDT 
Make sure BiquadFilterNode tail is getting processed.
Comment 1 Chris Dumez 2020-09-01 14:05:27 PDT 
Created attachment 407710 [details]
Patch
Comment 2 Darin Adler 2020-09-01 14:55:45 PDT 
Comment on attachment 407710 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407710&action=review

> Source/WebCore/Modules/webaudio/PannerNode.cpp:547
> +    return m_panner ? m_panner->requiresTailProcessing() : true;

I would write this as:

    return !m_panner || m_panner->requiresTailProcessing();

For me that seems more readable. Maybe other people find the ? : form more readable?

> Source/WebCore/Modules/webaudio/WebKitAudioPannerNode.cpp:355
> +    return m_panner ? m_panner->requiresTailProcessing() : true;

Ditto.
Comment 3 Chris Dumez 2020-09-01 16:11:59 PDT 
Committed r266417: <https://trac.webkit.org/changeset/266417>
Comment 4 Radar WebKit Bug Importer 2020-09-01 16:12:21 PDT 
<rdar://problem/68173068>