Bug 216044 - [Flatpak SDK] Adapt clean-webkit script to flatpak
Summary: [Flatpak SDK] Adapt clean-webkit script to flatpak
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Diego Pino
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-09-01 11:18 PDT by Diego Pino
Modified: 2020-09-01 21:51 PDT (History)
2 users (show)

See Also:


Attachments
Patch (2.66 KB, patch)
2020-09-01 11:19 PDT, Diego Pino
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Pino 2020-09-01 11:18:27 PDT
[Flatpak SDK] Adapt clean-webkit script to flatpak
Comment 1 Diego Pino 2020-09-01 11:19:49 PDT
Created attachment 407700 [details]
Patch
Comment 2 Diego Pino 2020-09-01 11:25:59 PDT
This script, clean-webkit, is used by the EWS in the 'unapply-patch' step. See:

https://ews-build.webkit-uat.org/#/builders/34/builds/4962

When passing the '--keep-jhbuild-directory' knob the script deletes everything inside 'WebKitBuild/' except 'DependenciesGTK/' and 'DependenciesWPE/'.

Since the EWS bots are using Flatpak, the script removes everything inside 'WebKitBuild/' and the following step 'compile-webkit-without-patch' fails because libwpe dependency is missing.
Comment 3 EWS 2020-09-01 21:50:39 PDT
Committed r266450: <https://trac.webkit.org/changeset/266450>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 407700 [details].
Comment 4 Radar WebKit Bug Importer 2020-09-01 21:51:14 PDT
<rdar://problem/68186945>