Bug 21603 - [GTK] Minor fixes to GOwnPtr
Summary: [GTK] Minor fixes to GOwnPtr
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Marco Barisione
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2008-10-14 15:18 PDT by Marco Barisione
Modified: 2008-10-17 14:17 PDT (History)
0 users

See Also:

Attachments
Patcj (5.62 KB, patch)
2008-10-14 16:13 PDT, Marco Barisione 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marco Barisione 2008-10-14 15:18:33 PDT 
As Darin asked on comment 10 to bug #20483 we should fix some minor issues in GOwnPtr:
- Style fixes
- freeOwnedPtr should be renamed to make it clear that it's for glib
- rawPtr should assert that the pointer is null
- rawPtr should have a better name
Comment 1 Marco Barisione 2008-10-14 16:13:40 PDT 
Created attachment 24351 [details]
Patcj
Comment 2 Jan Alonzo 2008-10-17 14:17:19 PDT 
Landed in r37660