Bug 216028 - Fix crash during WebPage constructor
Summary: Fix crash during WebPage constructor
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-08-31 21:06 PDT by Alex Christensen
Modified: 2020-09-02 09:48 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.57 KB, patch)
2020-08-31 21:07 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2020-08-31 21:06:44 PDT 
Fix crash during WebPage constructor
Comment 1 Alex Christensen 2020-08-31 21:07:01 PDT 
Created attachment 407656 [details]
Patch
Comment 2 Alex Christensen 2020-08-31 21:07:03 PDT 
<rdar://problem/67781279>
Comment 3 EWS 2020-08-31 22:51:42 PDT 
Found 16 new test failures: fast/css/continuationCrash.html, fast/css/text-overflow-input.html, fast/forms/button-positioned.html, fast/forms/button-sizes.html, fast/forms/input-button-sizes.html, fast/forms/input-disabled-color.html, fast/forms/input-readonly-dimmed.html, fast/forms/input-text-word-wrap.html, fast/forms/listbox-bidi-align.html, fast/forms/select-change-popup-to-listbox.html ...
Comment 4 EWS 2020-09-01 08:42:34 PDT 
Committed r266395: <https://trac.webkit.org/changeset/266395>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 407656 [details].
Comment 5 Alexey Proskuryakov 2020-09-02 09:48:33 PDT 
Comment on attachment 407656 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407656&action=review

> Source/WebKit/WebProcess/WebProcess.cpp:1149
> +        // This can be called during a WebPage's constructor, so wait until after the constructor returns to touch the WebPage.
> +        RunLoop::main().dispatch([this] {

I can see what issue you are fixing, but delaying on a timer is a super risky approach. What else can happen between now and when the timer fires? This leaves the page in an inconsistent state with no guarantee that it will remain dormant until the state is corrected.