RESOLVED FIXED216028
Fix crash during WebPage constructor 
https://bugs.webkit.org/show_bug.cgi?id=216028
Summary Fix crash during WebPage constructor
Alex Christensen
Reported 2020-08-31 21:06:44 PDT
Fix crash during WebPage constructor
Attachments
Patch (1.57 KB, patch)
2020-08-31 21:07 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2020-08-31 21:07:01 PDT
Created attachment 407656 [details] Patch
Alex Christensen
Comment 2 2020-08-31 21:07:03 PDT
<rdar://problem/67781279>
EWS
Comment 3 2020-08-31 22:51:42 PDT
Found 16 new test failures: fast/css/continuationCrash.html, fast/css/text-overflow-input.html, fast/forms/button-positioned.html, fast/forms/button-sizes.html, fast/forms/input-button-sizes.html, fast/forms/input-disabled-color.html, fast/forms/input-readonly-dimmed.html, fast/forms/input-text-word-wrap.html, fast/forms/listbox-bidi-align.html, fast/forms/select-change-popup-to-listbox.html ...
EWS
Comment 4 2020-09-01 08:42:34 PDT
Committed r266395: <https://trac.webkit.org/changeset/266395> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407656 [details].
Alexey Proskuryakov
Comment 5 2020-09-02 09:48:33 PDT
Comment on attachment 407656 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407656&action=review > Source/WebKit/WebProcess/WebProcess.cpp:1149 > + // This can be called during a WebPage's constructor, so wait until after the constructor returns to touch the WebPage. > + RunLoop::main().dispatch([this] { I can see what issue you are fixing, but delaying on a timer is a super risky approach. What else can happen between now and when the timer fires? This leaves the page in an inconsistent state with no guarantee that it will remain dormant until the state is corrected.
Note You need to log in before you can comment on or make changes to this bug.