Bug 216025 - Remove some PtrTag debugging code from release builds.
Summary: Remove some PtrTag debugging code from release builds.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-08-31 19:53 PDT by Mark Lam
Modified: 2020-09-01 12:27 PDT (History)
9 users (show)

See Also:


Attachments
proposed patch. (7.59 KB, patch)
2020-08-31 20:07 PDT, Mark Lam
saam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2020-08-31 19:53:32 PDT
<rdar://problem/68098263>
Comment 1 Mark Lam 2020-08-31 20:07:57 PDT
Created attachment 407652 [details]
proposed patch.
Comment 2 Saam Barati 2020-09-01 10:51:00 PDT
Comment on attachment 407652 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=407652&action=review

> Source/WTF/ChangeLog:11
> +        but is no longer needed for release builds.  Previously, we also use these

"we also use these" => "we used these"
Comment 3 Mark Lam 2020-09-01 11:53:47 PDT
Thanks for the review.  Landed in r266406: <http://trac.webkit.org/r266406>.