Bug 216021 - Some apps linked beyond iOS 13.4 don't respect mouse events, only touch events
Summary: Some apps linked beyond iOS 13.4 don't respect mouse events, only touch events
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-08-31 18:57 PDT by Tim Horton
Modified: 2020-09-01 11:52 PDT (History)
7 users (show)

See Also:

Attachments
Patch (8.96 KB, patch)
2020-08-31 19:03 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (8.78 KB, patch)
2020-09-01 10:49 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (8.78 KB, patch)
2020-09-01 10:52 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (8.76 KB, patch)
2020-09-01 11:07 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2020-08-31 18:57:17 PDT 
Some apps linked beyond iOS 13.4 don't respect mouse events, only touch events
Comment 1 Tim Horton 2020-08-31 19:03:48 PDT 
Created attachment 407647 [details]
Patch
Comment 2 Tim Horton 2020-08-31 19:03:50 PDT 
<rdar://problem/64830335>
Comment 3 Wenson Hsieh 2020-08-31 20:46:47 PDT 
Comment on attachment 407647 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407647&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:8604
> +        const char *warningVersion = "";

Nit - * on the other side.

I think you could also remove the `BOOL& shouldLogWarning` argument if you initialized this string to null, and then just checked for a non-null warningVersion below instead.
Comment 4 Tim Horton 2020-09-01 10:49:42 PDT 
Created attachment 407696 [details]
Patch
Comment 5 Tim Horton 2020-09-01 10:52:53 PDT 
Created attachment 407697 [details]
Patch
Comment 6 Tim Horton 2020-09-01 11:07:50 PDT 
Created attachment 407699 [details]
Patch
Comment 7 EWS 2020-09-01 11:52:03 PDT 
Committed r266407: <https://trac.webkit.org/changeset/266407>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 407699 [details].