Bug 216019 – Storage Access API: Allow requests for storage access from nested iframes

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[John Wilander]

It was decided browsers should support requests for storage access from nested iframes as part of the standardization of the Storage Access API. The issue is discussed here: https://github.com/privacycg/storage-access/issues/10

[Radar WebKit Bug Importer]

<rdar://problem/68109918>

[John Wilander]

Created attachment 407641 [details]
Patch

[John Wilander]

The mac-debug-wk1 bot seems to be in bad shape, exiting testing early.

[Kate Cheney]

Comment on attachment 407641 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407641&action=review

LGTM, it is one of those patches where the testing is far more complicated than the change!

> LayoutTests/http/tests/storageAccess/request-and-grant-access-cross-origin-sandboxed-nested-iframe-database.html:42
> +            testRunner.setStatisticsShouldBlockThirdPartyCookies(false, function() {

I believe this is set to false in WKWebsiteDataStoreStatisticsResetToConsistentState(), which is called between every test, so it should not be needed here.

> LayoutTests/http/tests/storageAccess/request-and-grant-access-cross-origin-sandboxed-nested-iframe.html:42
> +            testRunner.setStatisticsShouldBlockThirdPartyCookies(false, function() {

Ditto, this can just be setEnableFeature(false, finishJSTest);

[John Wilander]

(In reply to katherine_cheney from comment #4)
> Comment on attachment 407641 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=407641&action=review
> 
> LGTM, it is one of those patches where the testing is far more complicated
> than the change!

So true! But satisfying to make the change and immediately getting a failed test case.

> > LayoutTests/http/tests/storageAccess/request-and-grant-access-cross-origin-sandboxed-nested-iframe-database.html:42
> > +            testRunner.setStatisticsShouldBlockThirdPartyCookies(false, function() {
> 
> I believe this is set to false in
> WKWebsiteDataStoreStatisticsResetToConsistentState(), which is called
> between every test, so it should not be needed here.

Oh, I'll confirm and fix.

> > LayoutTests/http/tests/storageAccess/request-and-grant-access-cross-origin-sandboxed-nested-iframe.html:42
> > +            testRunner.setStatisticsShouldBlockThirdPartyCookies(false, function() {
> 
> Ditto, this can just be setEnableFeature(false, finishJSTest);

Ditto.

Thanks, Kate!

[John Wilander]

Created attachment 407708 [details]
Patch

[John Wilander]

Comment on attachment 407708 [details]
Patch

Thanks, Alex!

[EWS]

Committed r266479: <https://trac.webkit.org/changeset/266479>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 407708 [details].

[John Wilander]

*** Bug 205370 has been marked as a duplicate of this bug. ***

[John Wilander]

https://webkit.org/blog/11545/updates-to-the-storage-access-api/