The value of the attached date picker and the value of the inner control should match.
Created attachment 407687 [details] Patch
Comment on attachment 407687 [details] Patch It would be nice to have a test for this that sets the value in script and verifies that the UI updates to reflect the new value. Perhaps as a followup, though.
Created attachment 407714 [details] Patch
Comment on attachment 407714 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407714&action=review r=mews > Tools/TestRunnerShared/UIScriptContext/UIScriptController.h:220 > + virtual double dateTimePickerValue() const { notImplemented(); return false; } Perhaps return 0; instead of false? > Tools/WebKitTestRunner/mac/UIScriptControllerMac.mm:115 > + return [[(NSDatePicker*)subview dateValue] timeIntervalSince1970] * 1000; Nit - space before the * in NSDatePicker* > LayoutTests/fast/forms/date/date-editable-components/date-picker-update-on-edit.html:35 > + UIHelper.keyDown("3"); It seems like this test may need to be skipped on iOS, where we don’t use editable date fields.
Comment on attachment 407714 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407714&action=review >> LayoutTests/fast/forms/date/date-editable-components/date-picker-update-on-edit.html:35 >> + UIHelper.keyDown("3"); > > It seems like this test may need to be skipped on iOS, where we don’t use editable date fields. (Ah, never mind — this directory is skipped on iOS)
Created attachment 407716 [details] Patch for landing
ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.
Created attachment 407766 [details] Patch for landing
Committed r266461: <https://trac.webkit.org/changeset/266461> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407766 [details].
<rdar://problem/68211887>