Bug 215996 - [JSC] @defaultPromiseThen fast path should check species constructor
Summary: [JSC] @defaultPromiseThen fast path should check species constructor
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-08-30 22:26 PDT by Yusuke Suzuki
Modified: 2020-08-31 00:24 PDT (History)
9 users (show)

See Also:


Attachments
Patch (12.14 KB, patch)
2020-08-30 22:28 PDT, Yusuke Suzuki
no flags Details | Formatted Diff | Diff
Patch (12.15 KB, patch)
2020-08-30 23:05 PDT, Yusuke Suzuki
ross.kirsling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2020-08-30 22:26:10 PDT
[JSC] @defaultPromiseThen fast path should check species constructor
Comment 1 Yusuke Suzuki 2020-08-30 22:28:13 PDT
Created attachment 407587 [details]
Patch
Comment 2 Yusuke Suzuki 2020-08-30 23:05:44 PDT
Created attachment 407588 [details]
Patch
Comment 3 Ross Kirsling 2020-08-30 23:23:28 PDT
Comment on attachment 407588 [details]
Patch

r=me, now that I understand that we need to call @speciesConstructor from the enqueued job.
Comment 4 Yusuke Suzuki 2020-08-31 00:22:10 PDT
Mac-debug-wk1 failure and jsc failures are both flaky tests.
Comment 5 Yusuke Suzuki 2020-08-31 00:23:56 PDT
Committed r266346: <https://trac.webkit.org/changeset/266346>
Comment 6 Radar WebKit Bug Importer 2020-08-31 00:24:15 PDT
<rdar://problem/68057111>