Bug 215973 - Implement WEBGL_compressed_texture_s3tc_srgb extension
Summary: Implement WEBGL_compressed_texture_s3tc_srgb extension
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Darpinian
URL:
Keywords: InRadar
Depends on:
Blocks: 214640 215844
  Show dependency tree / graph
 
Reported: 2020-08-28 23:07 PDT by James Darpinian
Modified: 2020-10-17 20:22 PDT (History)
13 users (show)

See Also:

Attachments
Patch (31.32 KB, patch)
2020-08-28 23:38 PDT, James Darpinian 		no flags Details | Formatted Diff | Diff
rebase (31.29 KB, patch)
2020-08-28 23:47 PDT, James Darpinian 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Darpinian 2020-08-28 23:07:44 PDT 
Implement WEBGL_compressed_texture_s3tc_srgb extension
Comment 1 James Darpinian 2020-08-28 23:38:24 PDT 
Created attachment 407531 [details]
Patch
Comment 2 James Darpinian 2020-08-28 23:47:12 PDT 
Created attachment 407534 [details]
rebase
Comment 3 EWS Watchlist 2020-08-28 23:48:07 PDT 
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
Comment 4 James Darpinian 2020-08-29 00:00:20 PDT 
This fixes the Unity Tanks demo (see bug 215844) in WebGL 1. The demo assumes sRGB is available if S3TC is. (The demo is still broken in WebGL 2 due to another as yet unidentified bug.)
Comment 5 EWS 2020-08-31 11:59:13 PDT 
Committed r266364: <https://trac.webkit.org/changeset/266364>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 407534 [details].
Comment 6 Radar WebKit Bug Importer 2020-08-31 12:00:16 PDT 
<rdar://problem/68090510>
Comment 7 Alexey Proskuryakov 2020-10-17 12:19:03 PDT 
Comment on attachment 407534 [details]
rebase

View in context: https://bugs.webkit.org/attachment.cgi?id=407534&action=review

> Source/WebCore/ChangeLog:8
> +        Tested by webgl/2.0.0/conformance/extensions/webgl-compressed-texture-s3tc-srgb.html

In some sense, it is indeed, but the test passed before the change, and still passes after it.
Comment 8 James Darpinian 2020-10-17 20:22:45 PDT 
Yes, this is a problem common to all the extension tests. They trivially pass if the extension is not supported. Bug 217005 covers writing a separate test to check that the set of supported extensions is correct, but it's nontrivial because the result depends on the GPU hardware, not just the platform.