Bug 215971 - Text copied and pasted from Mac Catalyst apps appears larger than expected
Summary: Text copied and pasted from Mac Catalyst apps appears larger than expected
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-08-28 22:09 PDT by Wenson Hsieh
Modified: 2020-09-09 15:19 PDT (History)
9 users (show)

See Also:

Attachments
Patch (9.28 KB, patch)
2020-09-08 14:18 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Patch (9.26 KB, patch)
2020-09-09 12:32 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2020-08-28 22:09:43 PDT 
<rdar://problem/65768907>
Comment 1 Wenson Hsieh 2020-09-08 14:18:19 PDT 
Created attachment 408268 [details]
Patch
Comment 2 Alex Christensen 2020-09-09 09:46:29 PDT 
Comment on attachment 408268 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408268&action=review

> Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:176
> +            auto* uikitFramework = dlopen("/System/Library/Frameworks/UIKit.framework/UIKit", RTLD_NOW);

This should probably use the soft link macros like we do everywhere else in WebKit.  SOFT_LINK_OPTIONAL with a comment saying to remove it once rdar://problem/68524148 is available on all the bots.
Comment 3 Wenson Hsieh 2020-09-09 10:08:43 PDT 
(In reply to Alex Christensen from comment #2)
> Comment on attachment 408268 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=408268&action=review
> 
> > Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:176
> > +            auto* uikitFramework = dlopen("/System/Library/Frameworks/UIKit.framework/UIKit", RTLD_NOW);
> 
> This should probably use the soft link macros like we do everywhere else in
> WebKit.  SOFT_LINK_OPTIONAL with a comment saying to remove it once
> rdar://problem/68524148 is available on all the bots.

👍🏻
Comment 4 Wenson Hsieh 2020-09-09 12:32:38 PDT 
Created attachment 408358 [details]
Patch
Comment 5 Wenson Hsieh 2020-09-09 14:53:41 PDT 
Comment on attachment 408358 [details]
Patch

Thanks for the review!
Comment 6 EWS 2020-09-09 15:19:15 PDT 
Committed r266802: <https://trac.webkit.org/changeset/266802>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 408358 [details].