RESOLVED FIXED 215971
Text copied and pasted from Mac Catalyst apps appears larger than expected 
https://bugs.webkit.org/show_bug.cgi?id=215971
Summary Text copied and pasted from Mac Catalyst apps appears larger than expected
Wenson Hsieh
Reported 2020-08-28 22:09:43 PDT
<rdar://problem/65768907>
Attachments
Patch (9.28 KB, patch)
2020-09-08 14:18 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Patch (9.26 KB, patch)
2020-09-09 12:32 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2020-09-08 14:18:19 PDT
Created attachment 408268 [details] Patch
Alex Christensen
Comment 2 2020-09-09 09:46:29 PDT
Comment on attachment 408268 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408268&action=review > Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:176 > + auto* uikitFramework = dlopen("/System/Library/Frameworks/UIKit.framework/UIKit", RTLD_NOW); This should probably use the soft link macros like we do everywhere else in WebKit. SOFT_LINK_OPTIONAL with a comment saying to remove it once rdar://problem/68524148 is available on all the bots.
Wenson Hsieh
Comment 3 2020-09-09 10:08:43 PDT
(In reply to Alex Christensen from comment #2) > Comment on attachment 408268 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=408268&action=review > > > Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:176 > > + auto* uikitFramework = dlopen("/System/Library/Frameworks/UIKit.framework/UIKit", RTLD_NOW); > > This should probably use the soft link macros like we do everywhere else in > WebKit. SOFT_LINK_OPTIONAL with a comment saying to remove it once > rdar://problem/68524148 is available on all the bots. 👍🏻
Wenson Hsieh
Comment 4 2020-09-09 12:32:38 PDT
Created attachment 408358 [details] Patch
Wenson Hsieh
Comment 5 2020-09-09 14:53:41 PDT
Comment on attachment 408358 [details] Patch Thanks for the review!
EWS
Comment 6 2020-09-09 15:19:15 PDT
Committed r266802: <https://trac.webkit.org/changeset/266802> All reviewed patches have been landed. Closing bug and clearing flags on attachment 408358 [details].
Note You need to log in before you can comment on or make changes to this bug.