Bug 215969 - [JSC] for-of / for-in left-hand-side target should be simple-assignment-target
Summary: [JSC] for-of / for-in left-hand-side target should be simple-assignment-target
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
: 220506 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-08-28 21:00 PDT by Yusuke Suzuki
Modified: 2021-01-20 15:48 PST (History)
9 users (show)

See Also:


Attachments
Patch (27.59 KB, patch)
2020-08-28 21:40 PDT, Yusuke Suzuki
no flags Details | Formatted Diff | Diff
Patch (32.95 KB, patch)
2020-08-28 22:26 PDT, Yusuke Suzuki
ross.kirsling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2020-08-28 21:00:57 PDT
[JSC] for-of / for-in left-hand-side target should be simple-assignment-target
Comment 1 Yusuke Suzuki 2020-08-28 21:40:47 PDT
Created attachment 407523 [details]
Patch
Comment 2 Yusuke Suzuki 2020-08-28 22:26:42 PDT
Created attachment 407525 [details]
Patch
Comment 3 Ross Kirsling 2020-08-28 22:39:58 PDT
Comment on attachment 407525 [details]
Patch

Love it when the tests are the bulk of the patch. :D
Comment 4 Yusuke Suzuki 2020-08-29 00:49:42 PDT
Mac-debug-wk1 failures are know long-standing ones.

media/remote-control-command-seek.html
imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audionode-interface/audionode-connect-order.html
Comment 5 Yusuke Suzuki 2020-08-29 01:36:47 PDT
Windows failures are already happening in ToT. https://build.webkit.org/builders/Apple%20Win%2010%20Release%20%28Tests%29/builds/7693
Comment 6 Yusuke Suzuki 2020-08-29 01:38:15 PDT
Committed r266324: <https://trac.webkit.org/changeset/266324>
Comment 7 Radar WebKit Bug Importer 2020-08-29 01:39:17 PDT
<rdar://problem/67985272>
Comment 8 Mark Lam 2021-01-20 15:48:05 PST
*** Bug 220506 has been marked as a duplicate of this bug. ***